Skip to content

Commit fa0819e

Browse files
author
MarcoFalke
committed
doc: Move peer-review paragraph to right section
1 parent fa2b65b commit fa0819e

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

CONTRIBUTING.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ At this stage, one should expect comments and review from other contributors. Yo
191191
can add more commits to your pull request by committing them locally and pushing
192192
to your fork until you have satisfied all feedback.
193193

194-
Note: Code review is a burdensome but important part of the development process, and as such, certain types of pull requests are rejected. In general, if the **improvements** do not warrant the **review effort** required, the PR has a high chance of being rejected. It is up to the PR author to convince the reviewers that the changes warrant the review effort, and if reviewers are "Concept NACK'ing" the PR, the author may need to present arguments and/or do research backing their suggested changes.
194+
Please refer to the [peer review](#peer-review) section below for more details.
195195

196196
### Squashing Commits
197197

@@ -322,6 +322,14 @@ maintainers take into account the peer review when determining if there is
322322
consensus to merge a pull request (remember that discussions may have been
323323
spread out over GitHub, mailing list and IRC discussions).
324324

325+
Code review is a burdensome but important part of the development process, and
326+
as such, certain types of pull requests are rejected. In general, if the
327+
**improvements** do not warrant the **review effort** required, the PR has a
328+
high chance of being rejected. It is up to the PR author to convince the
329+
reviewers that the changes warrant the review effort, and if reviewers are
330+
"Concept NACK'ing" the PR, the author may need to present arguments and/or do
331+
research backing their suggested changes.
332+
325333
#### Conceptual Review
326334

327335
A review can be a conceptual review, where the reviewer leaves a comment

0 commit comments

Comments
 (0)