Skip to content

Commit f4ef856

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#26850: ci: Stop and remove CI container
fa0584e ci: Stop and remove CI container (MarcoFalke) fa5dccb scripted-diff: ci: Rework docker naming (MarcoFalke) Pull request description: This should not affect CI runs that have `DANGER_RUN_CI_ON_HOST=1` set, for example `.cirrus.yml`. However, when running CI locally with podman or docker, the container is stopped and thus deleted when all tests have passed. This feature was requested in bitcoin/bitcoin#26843 (comment) and can help to reduce used disk space when running several CI tasks subsequently. ACKs for top commit: fanquake: ACK fa0584e hebasto: ACK fa0584e, tested on Ubuntu 22.04. Tree-SHA512: 8bc1fabd15dad06d9ab3535d2743556137d512332b377b333ab13dbd7c5911b9295549511c6f3836b3acb7f8a39fb67e5f5249e45e1178d16ad4ed0593d05f04
2 parents fcd1a57 + fa0584e commit f4ef856

21 files changed

+42
-36
lines changed

ci/test/00_setup_env.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export RUN_FUZZ_TESTS=${RUN_FUZZ_TESTS:-false}
4848
export EXPECTED_TESTS_DURATION_IN_SECONDS=${EXPECTED_TESTS_DURATION_IN_SECONDS:-1000}
4949

5050
export CONTAINER_NAME=${CONTAINER_NAME:-ci_unnamed}
51-
export DOCKER_NAME_TAG=${DOCKER_NAME_TAG:-ubuntu:20.04}
51+
export CI_IMAGE_NAME_TAG=${CI_IMAGE_NAME_TAG:-ubuntu:20.04}
5252
# Randomize test order.
5353
# See https://www.boost.org/doc/libs/1_71_0/libs/test/doc/html/boost_test/utf_reference/rt_param_reference/random.html
5454
export BOOST_TEST_RANDOM=${BOOST_TEST_RANDOM:-1}
@@ -66,7 +66,7 @@ export BASE_OUTDIR=${BASE_OUTDIR:-$BASE_SCRATCH_DIR/out/$HOST}
6666
export BASE_BUILD_DIR=${BASE_BUILD_DIR:-$BASE_SCRATCH_DIR/build}
6767
export PREVIOUS_RELEASES_DIR=${PREVIOUS_RELEASES_DIR:-$BASE_ROOT_DIR/releases/$HOST}
6868
export SDK_URL=${SDK_URL:-https://bitcoincore.org/depends-sources/sdks}
69-
export DOCKER_PACKAGES=${DOCKER_PACKAGES:-build-essential libtool autotools-dev automake pkg-config bsdmainutils curl ca-certificates ccache python3 rsync git procps bison}
69+
export CI_BASE_PACKAGES=${CI_BASE_PACKAGES:-build-essential libtool autotools-dev automake pkg-config bsdmainutils curl ca-certificates ccache python3 rsync git procps bison}
7070
export GOAL=${GOAL:-install}
7171
export DIR_QA_ASSETS=${DIR_QA_ASSETS:-${BASE_SCRATCH_DIR}/qa-assets}
7272
export PATH=${BASE_ROOT_DIR}/ci/retry:$PATH

ci/test/00_setup_env_android.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export LC_ALL=C.UTF-8
99
export HOST=aarch64-linux-android
1010
export PACKAGES="unzip openjdk-8-jdk gradle"
1111
export CONTAINER_NAME=ci_android
12-
export DOCKER_NAME_TAG="ubuntu:focal"
12+
export CI_IMAGE_NAME_TAG="ubuntu:focal"
1313

1414
export RUN_UNIT_TESTS=false
1515
export RUN_FUNCTIONAL_TESTS=false

ci/test/00_setup_env_arm.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ if [ -n "$QEMU_USER_CMD" ]; then
1818
fi
1919
export CONTAINER_NAME=ci_arm_linux
2020
# Use debian to avoid 404 apt errors when cross compiling
21-
export DOCKER_NAME_TAG="debian:bullseye"
21+
export CI_IMAGE_NAME_TAG="debian:bullseye"
2222
export USE_BUSY_BOX=true
2323
export RUN_UNIT_TESTS=true
2424
export RUN_FUNCTIONAL_TESTS=false

ci/test/00_setup_env_i686_centos.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ export LC_ALL=C.UTF-8
88

99
export HOST=i686-pc-linux-gnu
1010
export CONTAINER_NAME=ci_i686_centos
11-
export DOCKER_NAME_TAG=quay.io/centos/centos:stream8
12-
export DOCKER_PACKAGES="gcc-c++ glibc-devel.x86_64 libstdc++-devel.x86_64 glibc-devel.i686 libstdc++-devel.i686 ccache libtool make git python3 python3-pip which patch lbzip2 xz procps-ng dash rsync coreutils bison"
11+
export CI_IMAGE_NAME_TAG=quay.io/centos/centos:stream8
12+
export CI_BASE_PACKAGES="gcc-c++ glibc-devel.x86_64 libstdc++-devel.x86_64 glibc-devel.i686 libstdc++-devel.i686 ccache libtool make git python3 python3-pip which patch lbzip2 xz procps-ng dash rsync coreutils bison"
1313
export PIP_PACKAGES="pyzmq"
1414
export GOAL="install"
1515
export BITCOIN_CONFIG="--enable-zmq --with-gui=qt5 --enable-reduce-exports"

ci/test/00_setup_env_i686_multiprocess.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export LC_ALL=C.UTF-8
88

99
export HOST=i686-pc-linux-gnu
1010
export CONTAINER_NAME=ci_i686_multiprocess
11-
export DOCKER_NAME_TAG=ubuntu:20.04
11+
export CI_IMAGE_NAME_TAG=ubuntu:20.04
1212
export PACKAGES="cmake python3 llvm clang g++-multilib"
1313
export DEP_OPTS="DEBUG=1 MULTIPROCESS=1"
1414
export GOAL="install"

ci/test/00_setup_env_mac.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
export LC_ALL=C.UTF-8
88

99
export CONTAINER_NAME=ci_macos_cross
10-
export DOCKER_NAME_TAG=ubuntu:20.04 # Check that Focal can cross-compile to macos
10+
export CI_IMAGE_NAME_TAG=ubuntu:20.04 # Check that Focal can cross-compile to macos
1111
export HOST=x86_64-apple-darwin
1212
export PACKAGES="cmake libz-dev libtinfo5 python3-setuptools xorriso"
1313
export XCODE_VERSION=12.2

ci/test/00_setup_env_native_asan.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ fi
2020

2121
export CONTAINER_NAME=ci_native_asan
2222
export PACKAGES="systemtap-sdt-dev clang llvm python3-zmq qtbase5-dev qttools5-dev-tools libevent-dev bsdmainutils libboost-dev libdb5.3++-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev libqrencode-dev libsqlite3-dev ${BPFCC_PACKAGE}"
23-
export DOCKER_NAME_TAG=ubuntu:22.04
23+
export CI_IMAGE_NAME_TAG=ubuntu:22.04
2424
export NO_DEPENDS=1
2525
export GOAL="install"
2626
export BITCOIN_CONFIG="--enable-c++20 --enable-usdt --enable-zmq --with-incompatible-bdb --with-gui=qt5 CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKORDER' --with-sanitizers=address,integer,undefined CC=clang CXX=clang++"

ci/test/00_setup_env_native_fuzz.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
export LC_ALL=C.UTF-8
88

9-
export DOCKER_NAME_TAG="ubuntu:22.04"
9+
export CI_IMAGE_NAME_TAG="ubuntu:22.04"
1010
export CONTAINER_NAME=ci_native_fuzz
1111
export PACKAGES="clang llvm python3 libevent-dev bsdmainutils libboost-dev libsqlite3-dev"
1212
export NO_DEPENDS=1

ci/test/00_setup_env_native_fuzz_with_msan.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
export LC_ALL=C.UTF-8
88

9-
export DOCKER_NAME_TAG="ubuntu:20.04"
9+
export CI_IMAGE_NAME_TAG="ubuntu:20.04"
1010
LIBCXX_DIR="${BASE_SCRATCH_DIR}/msan/build/"
1111
export MSAN_FLAGS="-fsanitize=memory -fsanitize-memory-track-origins=2 -fno-omit-frame-pointer -g -O1 -fno-optimize-sibling-calls"
1212
LIBCXX_FLAGS="-nostdinc++ -stdlib=libc++ -L${LIBCXX_DIR}lib -lc++abi -I${LIBCXX_DIR}include -I${LIBCXX_DIR}include/c++/v1 -lpthread -Wl,-rpath,${LIBCXX_DIR}lib -Wno-unused-command-line-argument"

ci/test/00_setup_env_native_fuzz_with_valgrind.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
export LC_ALL=C.UTF-8
88

9-
export DOCKER_NAME_TAG="ubuntu:22.04"
9+
export CI_IMAGE_NAME_TAG="ubuntu:22.04"
1010
export CONTAINER_NAME=ci_native_fuzz_valgrind
1111
export PACKAGES="clang llvm python3 libevent-dev bsdmainutils libboost-dev libsqlite3-dev valgrind"
1212
export NO_DEPENDS=1

0 commit comments

Comments
 (0)