Skip to content

Commit f1a19d7

Browse files
committed
Merge bitcoin/bitcoin#29537: lint: Misc improvements for lint runner
742d2b9 lint: Add lint runner build dir and lint pycache to clean task (Fabian Jahr) cfa057b lint: Add lint runner build dir to gitignore (Fabian Jahr) fad7f42 lint: Clarify lint runner rust dependency (Fabian Jahr) Pull request description: 1. Document the dependency to rust being installed locally 2. Add the build output directory to gitignore 3. Clean up the build output directory when running `make clean` ACKs for top commit: maflcko: ACK 742d2b9 TheCharlatan: ACK 742d2b9 Tree-SHA512: 36751d852e579830a9e6915b846886a6edaf4e42d508a4773ab502afda10b47c30c7c6bbd3e3158539ea5cf51592c2fe49c4221d271511006653a2d79119ed8c
2 parents 015ac13 + 742d2b9 commit f1a19d7

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ win32-build
130130
test/config.ini
131131
test/cache/*
132132
test/.mypy_cache/
133+
test/lint/test_runner/target/
133134

134135
!src/leveldb*/Makefile
135136

Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ clean-docs:
338338
clean-local: clean-docs
339339
rm -rf coverage_percent.txt test_bitcoin.coverage/ total.coverage/ fuzz.coverage/ test/tmp/ cache/ $(OSX_APP)
340340
rm -rf test/functional/__pycache__ test/functional/test_framework/__pycache__ test/cache share/rpcauth/__pycache__
341-
rm -rf osx_volname dist/
341+
rm -rf osx_volname dist/ test/lint/test_runner/target/ test/lint/__pycache__
342342

343343
test-security-check:
344344
if TARGET_DARWIN

test/lint/README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@ result is cached and it prevents issues when the image changes.
1616
test runner
1717
===========
1818

19-
To run all the lint checks in the test runner outside the docker, use:
19+
To run all the lint checks in the test runner outside the docker you first need
20+
to install the rust toolchain using your package manager of choice or
21+
[rustup](https://www.rust-lang.org/tools/install).
22+
23+
Then you can use:
2024

2125
```sh
2226
( cd ./test/lint/test_runner/ && cargo fmt && cargo clippy && RUST_BACKTRACE=1 cargo run )

0 commit comments

Comments
 (0)