Skip to content

Commit e912717

Browse files
committed
test: add missing comparison of node1's mempool in MempoolPackagesTest
1 parent a7129f8 commit e912717

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

test/functional/mempool_packages.py

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -199,13 +199,13 @@ def run_test(self):
199199
assert set(mempool1).issubset(set(mempool0))
200200
for tx in chain[:CUSTOM_ANCESTOR_LIMIT]:
201201
assert tx in mempool1
202-
# TODO: more detailed check of node1's mempool (fees etc.)
203-
# check transaction unbroadcast info (should be false if in both mempools)
204-
mempool = self.nodes[0].getrawmempool(True)
205-
for tx in mempool:
206-
assert_equal(mempool[tx]['unbroadcast'], False)
207-
208-
# TODO: test ancestor size limits
202+
entry0 = self.nodes[0].getmempoolentry(tx)
203+
entry1 = self.nodes[1].getmempoolentry(tx)
204+
assert not entry0['unbroadcast']
205+
assert not entry1['unbroadcast']
206+
assert_equal(entry1['fees']['base'], entry0['fees']['base'])
207+
assert_equal(entry1['vsize'], entry0['vsize'])
208+
assert_equal(entry1['depends'], entry0['depends'])
209209

210210
# Now test descendant chain limits
211211

@@ -251,10 +251,14 @@ def run_test(self):
251251
assert tx in mempool1
252252
for tx in chain[CUSTOM_DESCENDANT_LIMIT:]:
253253
assert tx not in mempool1
254-
# TODO: more detailed check of node1's mempool (fees etc.)
255-
256-
# TODO: test descendant size limits
257-
254+
for tx in mempool1:
255+
entry0 = self.nodes[0].getmempoolentry(tx)
256+
entry1 = self.nodes[1].getmempoolentry(tx)
257+
assert not entry0['unbroadcast']
258+
assert not entry1['unbroadcast']
259+
assert_equal(entry1['fees']['base'], entry0['fees']['base'])
260+
assert_equal(entry1['vsize'], entry0['vsize'])
261+
assert_equal(entry1['depends'], entry0['depends'])
258262
# Test reorg handling
259263
# First, the basics:
260264
self.generate(self.nodes[0], 1)

0 commit comments

Comments
 (0)