Skip to content

Commit d3cbcbf

Browse files
committed
ci: compile clang and compiler-rt in MSAN jobs
This works around https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005341.
1 parent 796bd1d commit d3cbcbf

File tree

3 files changed

+29
-8
lines changed

3 files changed

+29
-8
lines changed

ci/test/00_setup_env_native_fuzz_with_msan.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
export LC_ALL=C.UTF-8
88

99
export CI_IMAGE_NAME_TAG="ubuntu:23.04" # Version 23.04 will reach EOL in Jan 2024, and can be replaced by "ubuntu:24.04" (or anything else that ships the wanted clang version).
10-
LIBCXX_DIR="${BASE_SCRATCH_DIR}/msan/build/"
10+
LIBCXX_DIR="${BASE_SCRATCH_DIR}/msan/cxx_build/"
1111
export MSAN_FLAGS="-fsanitize=memory -fsanitize-memory-track-origins=2 -fno-omit-frame-pointer -g -O1 -fno-optimize-sibling-calls"
1212
LIBCXX_FLAGS="-nostdinc++ -nostdlib++ -isystem ${LIBCXX_DIR}include/c++/v1 -L${LIBCXX_DIR}lib -Wl,-rpath,${LIBCXX_DIR}lib -lc++ -lc++abi -lpthread -Wno-unused-command-line-argument"
1313
export MSAN_AND_LIBCXX_FLAGS="${MSAN_FLAGS} ${LIBCXX_FLAGS}"
1414

1515
export CONTAINER_NAME="ci_native_fuzz_msan"
16-
export PACKAGES="clang-16 llvm-16 libclang-rt-16-dev cmake"
16+
export PACKAGES="cmake ninja-build"
1717
# BDB generates false-positives and will be removed in future
1818
export DEP_OPTS="NO_BDB=1 NO_QT=1 CC=clang CXX=clang++ CFLAGS='${MSAN_FLAGS}' CXXFLAGS='${MSAN_AND_LIBCXX_FLAGS}'"
1919
export GOAL="install"

ci/test/00_setup_env_native_msan.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
export LC_ALL=C.UTF-8
88

99
export CI_IMAGE_NAME_TAG="ubuntu:23.04" # Version 23.04 will reach EOL in Jan 2024, and can be replaced by "ubuntu:24.04" (or anything else that ships the wanted clang version).
10-
LIBCXX_DIR="${BASE_SCRATCH_DIR}/msan/build/"
10+
LIBCXX_DIR="${BASE_SCRATCH_DIR}/msan/cxx_build/"
1111
export MSAN_FLAGS="-fsanitize=memory -fsanitize-memory-track-origins=2 -fno-omit-frame-pointer -g -O1 -fno-optimize-sibling-calls"
1212
LIBCXX_FLAGS="-nostdinc++ -nostdlib++ -isystem ${LIBCXX_DIR}include/c++/v1 -L${LIBCXX_DIR}lib -Wl,-rpath,${LIBCXX_DIR}lib -lc++ -lc++abi -lpthread -Wno-unused-command-line-argument"
1313
export MSAN_AND_LIBCXX_FLAGS="${MSAN_FLAGS} ${LIBCXX_FLAGS}"
1414

1515
export CONTAINER_NAME="ci_native_msan"
16-
export PACKAGES="clang-16 llvm-16 libclang-rt-16-dev cmake"
16+
export PACKAGES="cmake ninja-build"
1717
# BDB generates false-positives and will be removed in future
1818
export DEP_OPTS="NO_BDB=1 NO_QT=1 CC=clang CXX=clang++ CFLAGS='${MSAN_FLAGS}' CXXFLAGS='${MSAN_AND_LIBCXX_FLAGS}'"
1919
export GOAL="install"

ci/test/01_base_install.sh

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,32 @@ if [ -n "$PIP_PACKAGES" ]; then
4242
fi
4343

4444
if [[ ${USE_MEMORY_SANITIZER} == "true" ]]; then
45-
update-alternatives --install /usr/bin/clang++ clang++ "$(which clang++-16)" 100
46-
update-alternatives --install /usr/bin/clang clang "$(which clang-16)" 100
4745
git clone --depth=1 https://github.com/llvm/llvm-project -b llvmorg-16.0.4 "${BASE_SCRATCH_DIR}"/msan/llvm-project
48-
cmake -B "${BASE_SCRATCH_DIR}"/msan/build/ -DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi' -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_SANITIZER=MemoryWithOrigins -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF -DLIBCXX_ENABLE_DEBUG_MODE=ON -DLIBCXX_ENABLE_ASSERTIONS=ON -S "${BASE_SCRATCH_DIR}"/msan/llvm-project/runtimes
49-
make -C "${BASE_SCRATCH_DIR}"/msan/build/ "$MAKEJOBS"
46+
47+
cmake -G Ninja -B "${BASE_SCRATCH_DIR}"/msan/clang_build/ -DLLVM_ENABLE_PROJECTS="clang" \
48+
-DCMAKE_BUILD_TYPE=Release \
49+
-DLLVM_TARGETS_TO_BUILD=X86 \
50+
-DLLVM_ENABLE_RUNTIMES="compiler-rt;libcxx;libcxxabi;libunwind" \
51+
-S "${BASE_SCRATCH_DIR}"/msan/llvm-project/llvm
52+
53+
ninja -C "${BASE_SCRATCH_DIR}"/msan/clang_build/ "$MAKEJOBS"
54+
ninja -C "${BASE_SCRATCH_DIR}"/msan/clang_build/ install-runtimes
55+
56+
update-alternatives --install /usr/bin/clang++ clang++ "${BASE_SCRATCH_DIR}"/msan/clang_build/bin/clang++ 100
57+
update-alternatives --install /usr/bin/clang clang "${BASE_SCRATCH_DIR}"/msan/clang_build/bin/clang 100
58+
59+
cmake -G Ninja -B "${BASE_SCRATCH_DIR}"/msan/cxx_build/ -DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi' \
60+
-DCMAKE_BUILD_TYPE=Release \
61+
-DLLVM_USE_SANITIZER=MemoryWithOrigins \
62+
-DCMAKE_C_COMPILER=clang \
63+
-DCMAKE_CXX_COMPILER=clang++ \
64+
-DLLVM_TARGETS_TO_BUILD=X86 \
65+
-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF \
66+
-DLIBCXX_ENABLE_DEBUG_MODE=ON \
67+
-DLIBCXX_ENABLE_ASSERTIONS=ON \
68+
-S "${BASE_SCRATCH_DIR}"/msan/llvm-project/runtimes
69+
70+
ninja -C "${BASE_SCRATCH_DIR}"/msan/cxx_build/ "$MAKEJOBS"
5071
fi
5172

5273
if [[ "${RUN_TIDY}" == "true" ]]; then

0 commit comments

Comments
 (0)