Skip to content

Commit cf0711c

Browse files
committed
Merge bitcoin/bitcoin#27934: test: added coverage to estimatefee
d05be12 test: added coverage to estimatefee (kevkevin) Pull request description: Added a assert for an rpc error when we try to estimate fee for the max conf_target Line I am adding coverage to https://github.com/bitcoin/bitcoin/blob/master/src/rpc/fees.cpp#LL71C52-L71C52 ACKs for top commit: MarcoFalke: lgtm ACK d05be12 Tree-SHA512: dfab075989446e33d1a5ff1a308f1ba1b9f80cce3848fbe4231f69212ceef456a3f2b19365a42123e0397c31893fd9f1fd9973cc00cfbb324386e12ed0e6bccc
2 parents 41cb17f + d05be12 commit cf0711c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

test/functional/rpc_estimatefee.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ def run_test(self):
3636
assert_raises_rpc_error(-1, "estimatesmartfee", self.nodes[0].estimatesmartfee, 1, 'ECONOMICAL', 1)
3737
assert_raises_rpc_error(-1, "estimaterawfee", self.nodes[0].estimaterawfee, 1, 1, 1)
3838

39+
# max value of 1008 per src/policy/fees.h
40+
assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008", self.nodes[0].estimaterawfee, 1009)
41+
3942
# valid calls
4043
self.nodes[0].estimatesmartfee(1)
4144
# self.nodes[0].estimatesmartfee(1, None)

0 commit comments

Comments
 (0)