fuzz: don't allow adding duplicate transactions to the mempool

sdaftuar · sdaftuar · commit cc15c5bfd1eb · 2024-04-28T15:39:10.000-04:00
diff --git a/src/test/fuzz/partially_downloaded_block.cpp b/src/test/fuzz/partially_downloaded_block.cpp
@@ -72,7 +72,7 @@ FUZZ_TARGET(partially_downloaded_block, .init = initialize_pdb)
             available.insert(i);
         }
 
-        if (add_to_mempool) {
+        if (add_to_mempool && !pool.exists(GenTxid::Txid(tx->GetHash()))) {
             LOCK2(cs_main, pool.cs);
             pool.addUnchecked(ConsumeTxMemPoolEntry(fuzzed_data_provider, *tx));
             available.insert(i);

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ FUZZ_TARGET(partially_downloaded_block, .init = initialize_pdb)`
`72`	`72`	`available.insert(i);`
`73`	`73`	`}`
`74`	`74`
`75`		`- if (add_to_mempool) {`
	`75`	`+ if (add_to_mempool && !pool.exists(GenTxid::Txid(tx->GetHash()))) {`
`76`	`76`	`LOCK2(cs_main, pool.cs);`
`77`	`77`	`pool.addUnchecked(ConsumeTxMemPoolEntry(fuzzed_data_provider, *tx));`
`78`	`78`	`available.insert(i);`