Skip to content

Commit c407caa

Browse files
committed
Merge bitcoin/bitcoin#29687: cli: improve bitcoin-cli error when not connected
69d6fd6 cli: improve bitcoin-cli error when not connected (willcl-ark) Pull request description: Closes: #29555 Simply adds an additional suggestion to check `bitcoin-cli -help`. ACKs for top commit: maflcko: lgtm ACK 69d6fd6 itornaza: tested ACK 69d6fd6 tdb3: ACK for 69d6fd6 Tree-SHA512: af0c712bcc9b1267f81a8316d015bef99ab788ef43e3b450cdc4a9cb74004727d757d48f50d3af2b28b01be2931578623311677a79f1b148a53f364bd4279a0c
2 parents 1d8a5f0 + 69d6fd6 commit c407caa

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/bitcoin-cli.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,10 @@ static UniValue CallRPC(BaseRequestHandler* rh, const std::string& strMethod, co
827827
if (response.error != -1) {
828828
responseErrorMessage = strprintf(" (error code %d - \"%s\")", response.error, http_errorstring(response.error));
829829
}
830-
throw CConnectionFailed(strprintf("Could not connect to the server %s:%d%s\n\nMake sure the bitcoind server is running and that you are connecting to the correct RPC port.", host, port, responseErrorMessage));
830+
throw CConnectionFailed(strprintf("Could not connect to the server %s:%d%s\n\n"
831+
"Make sure the bitcoind server is running and that you are connecting to the correct RPC port.\n"
832+
"Use \"bitcoin-cli -help\" for more info.",
833+
host, port, responseErrorMessage));
831834
} else if (response.status == HTTP_UNAUTHORIZED) {
832835
if (failedToGetAuthCookie) {
833836
throw std::runtime_error(strprintf(

0 commit comments

Comments
 (0)