Skip to content

Commit c37fb25

Browse files
committed
Merge bitcoin/bitcoin#27176: docs: GetDataDirNet and GetDataDirBase don't create datadir
fb0dbe9 docs: GetDataDirNet and GetDataDirBase don't create datadir (stickies-v) Pull request description: Since #27073, the behaviour of `GetDataDir()` [changed](https://github.com/bitcoin/bitcoin/pull/27073/files#diff-19427b0dd1a791adc728c82e88f267751ba4f1c751e19262cac03cccd2822216L435-L443) to only return the datadir path, but not create it if non-existent. This also changed the behaviour of `GetDataDirNet()` and `GetDataDirBase()` but the docs do not yet reflect that. ACKs for top commit: TheCharlatan: ACK fb0dbe9 theStack: ACK fb0dbe9 willcl-ark: ACK fb0dbe9 Tree-SHA512: 3f10f4871df59882f3649c6d3b2362cae2f8a01ad0bd0c636c5608b0d177d279a2e8712930b819d6d3912e91fa6447b9e54507c33d8afe427f7f39002b013bfb
2 parents bb136aa + fb0dbe9 commit c37fb25

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/util/system.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,15 +287,13 @@ class ArgsManager
287287
* Get data directory path
288288
*
289289
* @return Absolute path on success, otherwise an empty path when a non-directory path would be returned
290-
* @post Returned directory path is created unless it is empty
291290
*/
292291
const fs::path& GetDataDirBase() const { return GetDataDir(false); }
293292

294293
/**
295294
* Get data directory path with appended network identifier
296295
*
297296
* @return Absolute path on success, otherwise an empty path when a non-directory path would be returned
298-
* @post Returned directory path is created unless it is empty
299297
*/
300298
const fs::path& GetDataDirNet() const { return GetDataDir(true); }
301299

0 commit comments

Comments
 (0)