Skip to content

Commit c00bc63

Browse files
committed
Merge bitcoin/bitcoin#28288: test: fix 'unknown named parameter' test in wallet_basic
452c094 test: fix 'unknown named parameter' test in `wallet_basic` (brunoerg) Pull request description: This PR removes loop when testing an unknown named parameter. They don't have any effect. ACKs for top commit: jonatack: ACK 452c094 theStack: re-ACK 452c094 Tree-SHA512: cf1a37d738bb6fdf9817e7b1d33bc69643dae61e3dbfae5c1e9f26220c55db6f134018dd9a1c65c13869ee58bcb6f3337c5999aabf2614d3126fbc01270705e8
2 parents a84dade + 452c094 commit c00bc63

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

test/functional/wallet_basic.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -310,8 +310,7 @@ def run_test(self):
310310
node_0_bal += amount
311311
assert_equal(self.nodes[0].getbalance(), node_0_bal)
312312

313-
for key in ["totalFee", "feeRate"]:
314-
assert_raises_rpc_error(-8, "Unknown named parameter key", self.nodes[2].sendtoaddress, address=address, amount=1, fee_rate=1, key=1)
313+
assert_raises_rpc_error(-8, "Unknown named parameter feeRate", self.nodes[2].sendtoaddress, address=address, amount=1, fee_rate=1, feeRate=1)
315314

316315
# Test setting explicit fee rate just below the minimum.
317316
self.log.info("Test sendmany raises 'fee rate too low' if fee_rate of 0.99999999 is passed")
@@ -505,9 +504,6 @@ def run_test(self):
505504
fee = prebalance - postbalance - amount
506505
assert_fee_amount(fee, tx_size, Decimal(fee_rate_btc_kvb))
507506

508-
for key in ["totalFee", "feeRate"]:
509-
assert_raises_rpc_error(-8, "Unknown named parameter key", self.nodes[2].sendtoaddress, address=address, amount=1, fee_rate=1, key=1)
510-
511507
# Test setting explicit fee rate just below the minimum.
512508
self.log.info("Test sendtoaddress raises 'fee rate too low' if fee_rate of 0.99999999 is passed")
513509
assert_raises_rpc_error(-6, "Fee rate (0.999 sat/vB) is lower than the minimum fee rate setting (1.000 sat/vB)",

0 commit comments

Comments
 (0)