Skip to content

Commit bf9361d

Browse files
committed
Merge bitcoin/bitcoin#26941: test: Fix intermittent feature_rbf issue
fa88c04 test: Fix intermittent feature_rbf issue (MarcoFalke) Pull request description: The miniwallet will rescan the chain and mempool on construction. If the mempools are still in sync, it may lead to crashes. Fix that by moving the sync first. Fixes #26937 ACKs for top commit: theStack: Code-review ACK fa88c04 Tree-SHA512: 5ffcd5e91118b57811b62f12454da8ae3ca98ffad175cd895cd41b63d7cf420906b1e15a4d4489d223d6b21ab796f9839676af8a5f340c606868bc249f4ea340
2 parents c0b6c40 + fa88c04 commit bf9361d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/functional/feature_rbf.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -392,11 +392,11 @@ def test_too_many_replacements_with_default_mempool_params(self):
392392
enough transactions off of each root UTXO to exceed the MAX_REPLACEMENT_LIMIT.
393393
Then create a conflicting RBF replacement transaction.
394394
"""
395-
normal_node = self.nodes[1]
396-
wallet = MiniWallet(normal_node)
397395
# Clear mempools to avoid cross-node sync failure.
398396
for node in self.nodes:
399397
self.generate(node, 1)
398+
normal_node = self.nodes[1]
399+
wallet = MiniWallet(normal_node)
400400

401401
# This has to be chosen so that the total number of transactions can exceed
402402
# MAX_REPLACEMENT_LIMIT without having any one tx graph run into the descendant

0 commit comments

Comments
 (0)