thread-safety: add missing lock annotation

theuni · theuni · commit aeea5f0ec112 · 2025-05-08T20:14:00.000Z
No warning is currently emitted because our reverse_lock does not enforce our
thread-safety annotations. Once it is fixed, the unlock would cause a warning.
diff --git a/src/node/interfaces.cpp b/src/node/interfaces.cpp
@@ -431,7 +431,7 @@ class NodeImpl : public Node
 };
 
 // NOLINTNEXTLINE(misc-no-recursion)
-bool FillBlock(const CBlockIndex* index, const FoundBlock& block, UniqueLock<RecursiveMutex>& lock, const CChain& active, const BlockManager& blockman)
+bool FillBlock(const CBlockIndex* index, const FoundBlock& block, UniqueLock<RecursiveMutex>& lock, const CChain& active, const BlockManager& blockman) EXCLUSIVE_LOCKS_REQUIRED(cs_main)
 {
     if (!index) return false;
     if (block.m_hash) *block.m_hash = index->GetBlockHash();

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ class NodeImpl : public Node`
`431`	`431`	`};`
`432`	`432`
`433`	`433`	`// NOLINTNEXTLINE(misc-no-recursion)`
`434`		`-bool FillBlock(const CBlockIndex* index, const FoundBlock& block, UniqueLock<RecursiveMutex>& lock, const CChain& active, const BlockManager& blockman)`
	`434`	`+bool FillBlock(const CBlockIndex* index, const FoundBlock& block, UniqueLock<RecursiveMutex>& lock, const CChain& active, const BlockManager& blockman) EXCLUSIVE_LOCKS_REQUIRED(cs_main)`
`435`	`435`	`{`
`436`	`436`	`if (!index) return false;`
`437`	`437`	`if (block.m_hash) *block.m_hash = index->GetBlockHash();`