Merge bitcoin/bitcoin#30097: crypto: disable asan for sha256_sse4 with clang and -O0

fanquake · fanquake · commit ae2658caacc1 · 2024-05-16T08:40:34.000+08:00
141df0a crypto: disable asan for sha256_sse4 with clang and -O0 (Cory Fields) Pull request description: Clang is unable to compile the Transform function for that combination of options. Fixes #29801. ACKs for top commit: achow101: ACK 141df0a Tree-SHA512: d74fdac5840ad7524edfde069fb43ae75c31146e90ecc58bbc7912ff57a02b068547431b1766afeed782272c0b93b0b41a286c1cf26ec55ce332d94ce917d810
diff --git a/src/crypto/sha256_sse4.cpp b/src/crypto/sha256_sse4.cpp
@@ -13,6 +13,13 @@
 namespace sha256_sse4
 {
 void Transform(uint32_t* s, const unsigned char* chunk, size_t blocks)
+#if defined(__clang__) && !defined(__OPTIMIZE__)
+  /*
+  clang is unable to compile this with -O0 and -fsanitize=address.
+  See upstream bug: https://github.com/llvm/llvm-project/issues/92182
+  */
+  __attribute__((no_sanitize("address")))
+#endif
 {
     static const uint32_t K256 alignas(16) [] = {
         0x428a2f98, 0x71374491, 0xb5c0fbcf, 0xe9b5dba5,

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,13 @@`
`13`	`13`	`namespace sha256_sse4`
`14`	`14`	`{`
`15`	`15`	`void Transform(uint32_t* s, const unsigned char* chunk, size_t blocks)`
	`16`	`+#if defined(__clang__) && !defined(__OPTIMIZE__)`
	`17`	`+ /*`
	`18`	`+ clang is unable to compile this with -O0 and -fsanitize=address.`
	`19`	`+ See upstream bug: https://github.com/llvm/llvm-project/issues/92182`
	`20`	`+ */`
	`21`	`+ __attribute__((no_sanitize("address")))`
	`22`	`+#endif`
`16`	`23`	`{`
`17`	`24`	`static const uint32_t K256 alignas(16) [] = {`
`18`	`25`	`0x428a2f98, 0x71374491, 0xb5c0fbcf, 0xe9b5dba5,`