run_command: Enable close_fds option to avoid lingering fds

luke-jr · laanwj · commit a0eed55398f8 · 2025-05-01T11:18:04.000+02:00
diff --git a/src/common/run_command.cpp b/src/common/run_command.cpp
@@ -24,7 +24,7 @@ UniValue RunCommandParseJSON(const std::string& str_command, const std::string&
 
     if (str_command.empty()) return UniValue::VNULL;
 
-    auto c = sp::Popen(str_command, sp::input{sp::PIPE}, sp::output{sp::PIPE}, sp::error{sp::PIPE});
+    auto c = sp::Popen(str_command, sp::input{sp::PIPE}, sp::output{sp::PIPE}, sp::error{sp::PIPE}, sp::close_fds{true});
     if (!str_std_in.empty()) {
         c.send(str_std_in);
     }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ UniValue RunCommandParseJSON(const std::string& str_command, const std::string&`
`24`	`24`
`25`	`25`	`if (str_command.empty()) return UniValue::VNULL;`
`26`	`26`
`27`		`- auto c = sp::Popen(str_command, sp::input{sp::PIPE}, sp::output{sp::PIPE}, sp::error{sp::PIPE});`
	`27`	`+ auto c = sp::Popen(str_command, sp::input{sp::PIPE}, sp::output{sp::PIPE}, sp::error{sp::PIPE}, sp::close_fds{true});`
`28`	`28`	`if (!str_std_in.empty()) {`
`29`	`29`	`c.send(str_std_in);`
`30`	`30`	`}`