Skip to content

Commit 99e35fb

Browse files
committed
Merge bitcoin/bitcoin#30779: doc: add -DWITH_BDB=ON to unix build docs
ddef914 doc: remove extraneous install statement (tdb3) bc532c9 doc: add with_bdb to unix build docs (tdb3) Pull request description: Existing instructions for building legacy wallet support omit `-DWITH_BDB=ON`, which results in: ``` CMake Warning: Manually-specified variables were not used by the project: BerkeleyDB_INCLUDE_DIR ``` and a build without BDB support. This PR updates the docs to include `-DWITH_BDB=ON`. Also adds a minor correction to the OpenBSD build doc. Checked by building on Linux (Debian 12.7), FreeBSD 14.1, and OpenBSD 7.5 and attempting to create a legacy wallet with the `createwallet` rpc (with `-deprecatedrpc=create_bdb`). ACKs for top commit: l0rinc: utACK ddef914 fanquake: ACK ddef914 Tree-SHA512: 261568700b95fc073e03db6ca64a5f0544d5aed337aee4275575c1d0d1373c2a96911947abd202da3ed7c3b7a662b700b0596c0dabefe4b50900a798eed7e118
2 parents 0533e65 + ddef914 commit 99e35fb

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

doc/build-freebsd.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ Run `cmake -B build -LH` to see the full list of available options.
118118
This enables support for both wallet types, assuming
119119
`sqlite3` and `db4` are both installed.
120120
```bash
121-
cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include"
121+
cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include" -DWITH_BDB=ON
122122
```
123123

124124
##### No Wallet or GUI

doc/build-openbsd.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ There is an included test suite that is useful for testing code changes when dev
9090
To run the test suite (recommended), you will need to have Python 3 installed:
9191

9292
```bash
93-
pkg_add install python # Select the newest version of the package.
93+
pkg_add python # Select the newest version of the package.
9494
```
9595

9696
## Building Bitcoin Core
@@ -112,7 +112,7 @@ Run `cmake -B build -LH` to see the full list of available options.
112112
This enables support for both wallet types:
113113

114114
```bash
115-
cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include"
115+
cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include" -DWITH_BDB=ON
116116
```
117117

118118
### 2. Compile

doc/build-unix.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ and configure using the following:
161161
```bash
162162
export BDB_PREFIX="/path/to/bitcoin/depends/x86_64-pc-linux-gnu"
163163

164-
cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include"
164+
cmake -B build -DBerkeleyDB_INCLUDE_DIR:PATH="${BDB_PREFIX}/include" -DWITH_BDB=ON
165165
```
166166

167167
**Note**: Make sure that `BDB_PREFIX` is an absolute path.

0 commit comments

Comments
 (0)