Skip to content

Commit 8f1185f

Browse files
committed
Merge bitcoin/bitcoin#29805: test: Fix debug recommendation in argsman_tests
561a650 test: Fix debug recommendation in argsman_tests (Fabian Jahr) Pull request description: There are recommendations in the `argsman_tests` comments on how to re-run and debug a test failure to see if it reflects an expected or unexpected change. The command tries to run a test in `util_tests` but this is in `argsman_tests` so the command doesn't work with just copy+paste. I didn't investigate further but I suspect that these tests were moved between files. ACKs for top commit: fanquake: ACK 561a650 Tree-SHA512: b3bb94ba1635c9455149b455f2b30ee37a8067a6242339531ab54d428177a288da29a4a10702652305eb34aa7638f51dad35fa6b0e7b74617e445327b8c4c053
2 parents 3a8dc56 + 561a650 commit 8f1185f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/test/argsman_tests.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -904,7 +904,7 @@ BOOST_FIXTURE_TEST_CASE(util_ArgsMerge, ArgsMergeTestingSetup)
904904

905905
// If check below fails, should manually dump the results with:
906906
//
907-
// ARGS_MERGE_TEST_OUT=results.txt ./test_bitcoin --run_test=util_tests/util_ArgsMerge
907+
// ARGS_MERGE_TEST_OUT=results.txt ./test_bitcoin --run_test=argsman_tests/util_ArgsMerge
908908
//
909909
// And verify diff against previous results to make sure the changes are expected.
910910
//
@@ -1007,7 +1007,7 @@ BOOST_FIXTURE_TEST_CASE(util_ChainMerge, ChainMergeTestingSetup)
10071007

10081008
// If check below fails, should manually dump the results with:
10091009
//
1010-
// CHAIN_MERGE_TEST_OUT=results.txt ./test_bitcoin --run_test=util_tests/util_ChainMerge
1010+
// CHAIN_MERGE_TEST_OUT=results.txt ./test_bitcoin --run_test=argsman_tests/util_ChainMerge
10111011
//
10121012
// And verify diff against previous results to make sure the changes are expected.
10131013
//

0 commit comments

Comments
 (0)