Skip to content

Commit 8d39c63

Browse files
committed
Merge #16952: gui: make sure to update the UI when deleting a transaction
addaf8a make sure to update the UI when deleting a transaction (Jonas Schnelli) Pull request description: `CWallet::ZapSelectTx` removes transactions from the internal model, but leaves the UI in the dark. Adding a `NotifyTransactionChanged()` should avoid having invalid transactions in the GUI. Fixes #16950 ACKs for top commit: fanquake: ACK addaf8a - tested that this fixes #16950 Sjors: tACK addaf8a: tested with an unpruned wallet by calling `removeprunedfunds` on an RBF-replaced transaction. It neatly disappears from the UI. kristapsk: ACK addaf8a (tested both with and without this change) Tree-SHA512: 65e8c690847f7499e82c9fef67b60d9aaa63c853732fe7fa7281da33054fcdcd9d24f5b86de71b0827728c25bac8efb7db445863f990304ebfee6fc450620c47
2 parents ddc4e3c + addaf8a commit 8d39c63

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/wallet/wallet.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3376,6 +3376,7 @@ DBErrors CWallet::ZapSelectTx(std::vector<uint256>& vHashIn, std::vector<uint256
33763376
const auto& it = mapWallet.find(hash);
33773377
wtxOrdered.erase(it->second.m_it_wtxOrdered);
33783378
mapWallet.erase(it);
3379+
NotifyTransactionChanged(this, hash, CT_DELETED);
33793380
}
33803381

33813382
if (nZapSelectTxRet == DBErrors::NEED_REWRITE)

0 commit comments

Comments
 (0)