Skip to content

Commit 83436d1

Browse files
committed
serialization: Drop unnecessary ParamsStream references
Drop unnecessary ParamsStream references from CTransaction and CMutableTransaction constructors. This just couples these classes unnecessarily to the ParamsStream class, making the ParamsStream class harder to modify, and making the transaction classes in some cases (depending on parameter order) unable to work with stream classes that have multiple parameters set.
1 parent 84502b7 commit 83436d1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/primitives/transaction.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ class CTransaction
334334
template <typename Stream>
335335
CTransaction(deserialize_type, const TransactionSerParams& params, Stream& s) : CTransaction(CMutableTransaction(deserialize, params, s)) {}
336336
template <typename Stream>
337-
CTransaction(deserialize_type, ParamsStream<TransactionSerParams,Stream>& s) : CTransaction(CMutableTransaction(deserialize, s)) {}
337+
CTransaction(deserialize_type, Stream& s) : CTransaction(CMutableTransaction(deserialize, s)) {}
338338

339339
bool IsNull() const {
340340
return vin.empty() && vout.empty();
@@ -400,7 +400,7 @@ struct CMutableTransaction
400400
}
401401

402402
template <typename Stream>
403-
CMutableTransaction(deserialize_type, ParamsStream<TransactionSerParams,Stream>& s) {
403+
CMutableTransaction(deserialize_type, Stream& s) {
404404
Unserialize(s);
405405
}
406406

0 commit comments

Comments
 (0)