Skip to content

Commit 7fee0ca

Browse files
committed
Merge bitcoin/bitcoin#29976: build, msvc: Drop duplicated common\url.cpp source file
97a4ad5 build, msvc: Drop duplicated `common\url.cpp` source file (Hennadii Stepanov) Pull request description: After bitcoin/bitcoin#29904, the `common\url.cpp` source file is included into the `SOURCE_FILES` by the `msvc-autogen.py` script. Removes a compiler [warning](https://github.com/bitcoin/bitcoin/actions/runs/8853698173/job/24315127236#step:20:1776): ``` url.obj : warning LNK4006: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl UrlDecode(class std::basic_string_view<char,struct std::char_traits<char> >)" (?UrlDecode@@ya?AV?$basic_string@DU?$char_traits@D@std@@v?$allocator@D@2@@std@@v?$basic_string_view@DU?$char_traits@D@std@@@2@@z) already defined in common_url.obj; second definition ignored [D:\a\bitcoin\bitcoin\build_msvc\libbitcoin_common\libbitcoin_common.vcxproj] ``` ACKs for top commit: fanquake: ACK 97a4ad5 Tree-SHA512: 294955d6e6940b48a429e2302fb456706a5c62515d479398036b40716ee6b722535876adeb9b988ddb8fc942fabc39fe358c50eff0baaae92bd24bbeb4362885
2 parents 1ffbd96 + 97a4ad5 commit 7fee0ca

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

build_msvc/libbitcoin_common/libbitcoin_common.vcxproj.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<ConfigurationType>StaticLibrary</ConfigurationType>
99
</PropertyGroup>
1010
<ItemGroup>
11-
<ClCompile Include="..\..\src\common\url.cpp" />
1211
@SOURCE_FILES@
1312
</ItemGroup>
1413
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />

0 commit comments

Comments
 (0)