Skip to content

Commit 7763e86

Browse files
committed
Merge bitcoin/bitcoin#32573: ci: Avoid && dropping errors
fab97f5 ci: Avoid && dropping errors (MarcoFalke) Pull request description: In bash, `&&` will ignore errexit. This can lead to silently ignoring errors. Compare the output of: ``` $ bash -c 'set -xe; false && false ; true; echo $?' + false + true + echo 0 0 ``` In theory this could be fixed by using a subshell: ``` $ bash -c 'set -xe; ( false && false ) ; true; echo $?' + false ``` However, it is easier to just remove the `&&`. This was introduced in commit faa807b ACKs for top commit: janb84: Code review ACK bitcoin/bitcoin@fab97f5 hebasto: ACK fab97f5. laanwj: ACK fab97f5 Tree-SHA512: 9d034829e03ef3aefdaad82c3cab59bf3fe18529762271c1ad3c838357e337e94bd403b77e30c0cf69715254b65addff6d12f2fb497d7a0e2cdcbcbf78858d47
2 parents 0a56ed1 + fab97f5 commit 7763e86

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/ci-test-each-commit-exec.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ echo "Running test-one-commit on $( git log -1 )"
1414
# Use clang++, because it is a bit faster and uses less memory than g++
1515
CC=clang CXX=clang++ cmake -B build -DWERROR=ON -DWITH_ZMQ=ON -DBUILD_GUI=ON -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWITH_USDT=ON -DCMAKE_CXX_FLAGS='-Wno-error=unused-member-function'
1616

17-
cmake --build build -j "$( nproc )" && ctest --output-on-failure --stop-on-failure --test-dir build -j "$( nproc )"
17+
cmake --build build -j "$( nproc )"
18+
19+
ctest --output-on-failure --stop-on-failure --test-dir build -j "$( nproc )"
1820

1921
./build/test/functional/test_runner.py -j $(( $(nproc) * 2 )) --combinedlogslen=99999999

0 commit comments

Comments
 (0)