Skip to content

Commit 72b763e

Browse files
committed
wallet: annotate bools in descriptor SPKM FillPSBT()
1 parent 32f9ce0 commit 72b763e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/wallet/scriptpubkeyman.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2495,7 +2495,7 @@ TransactionError DescriptorScriptPubKeyMan::FillPSBT(PartiallySignedTransaction&
24952495
input.FillSignatureData(sigdata);
24962496

24972497
std::unique_ptr<FlatSigningProvider> keys = std::make_unique<FlatSigningProvider>();
2498-
std::unique_ptr<FlatSigningProvider> script_keys = GetSigningProvider(script, sign);
2498+
std::unique_ptr<FlatSigningProvider> script_keys = GetSigningProvider(script, /*include_private=*/sign);
24992499
if (script_keys) {
25002500
keys->Merge(std::move(*script_keys));
25012501
} else {
@@ -2536,7 +2536,7 @@ TransactionError DescriptorScriptPubKeyMan::FillPSBT(PartiallySignedTransaction&
25362536
}
25372537
}
25382538

2539-
SignPSBTInput(HidingSigningProvider(keys.get(), !sign, !bip32derivs), psbtx, i, &txdata, sighash_type, nullptr, finalize);
2539+
SignPSBTInput(HidingSigningProvider(keys.get(), /*hide_secret=*/!sign, /*hide_origin=*/!bip32derivs), psbtx, i, &txdata, sighash_type, nullptr, finalize);
25402540

25412541
bool signed_one = PSBTInputSigned(input);
25422542
if (n_signed && (signed_one || !sign)) {
@@ -2553,7 +2553,7 @@ TransactionError DescriptorScriptPubKeyMan::FillPSBT(PartiallySignedTransaction&
25532553
if (!keys) {
25542554
continue;
25552555
}
2556-
UpdatePSBTOutput(HidingSigningProvider(keys.get(), true, !bip32derivs), psbtx, i);
2556+
UpdatePSBTOutput(HidingSigningProvider(keys.get(), /*hide_secret=*/true, /*hide_origin=*/!bip32derivs), psbtx, i);
25572557
}
25582558

25592559
return TransactionError::OK;

0 commit comments

Comments
 (0)