Skip to content

Commit 6ee3997

Browse files
committed
test: removes unnecessary check from validation_tests
An unnecessary check was added to the block mutation tests in #29412 where IsBlockMutated is returning true for the invalid reasons: we try to check mutation via transaction duplication, but the merkle root is not updated before the check, therefore the check fails because the provided root and the computed root differ, but not because the block contains the same transaction twice. The check is meaningless so it can be removed.
1 parent 2649e65 commit 6ee3997

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/test/validation_tests.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,6 @@ BOOST_AUTO_TEST_CASE(block_malleation)
233233
// Block with two transactions is mutated if any node is duplicate.
234234
{
235235
block.vtx[1] = block.vtx[0];
236-
BOOST_CHECK(is_mutated(block, /*check_witness_root=*/false));
237236
HashWriter hasher;
238237
hasher.write(block.vtx[0]->GetHash());
239238
hasher.write(block.vtx[1]->GetHash());

0 commit comments

Comments
 (0)