refactor: Avoid implicit-integer-sign-change in createTransaction

MarcoFalke · MarcoFalke · commit 6d8eecd33a52 · 2024-03-21T19:32:12.000+01:00
diff --git a/src/wallet/interfaces.cpp b/src/wallet/interfaces.cpp
@@ -286,7 +286,7 @@ class WalletImpl : public Wallet
         if (!res) return util::Error{util::ErrorString(res)};
         const auto& txr = *res;
         fee = txr.fee;
-        change_pos = txr.change_pos ? *txr.change_pos : -1;
+        change_pos = txr.change_pos ? int(*txr.change_pos) : -1;
 
         return txr.tx;
     }

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ class WalletImpl : public Wallet`
`286`	`286`	`if (!res) return util::Error{util::ErrorString(res)};`
`287`	`287`	`const auto& txr = *res;`
`288`	`288`	`fee = txr.fee;`
`289`		`- change_pos = txr.change_pos ? *txr.change_pos : -1;`
	`289`	`+ change_pos = txr.change_pos ? int(*txr.change_pos) : -1;`
`290`	`290`
`291`	`291`	`return txr.tx;`
`292`	`292`	`}`