Drop unneeded lock from createNewBlock

Sjors · Sjors · commit 5fb2b704897f · 2024-06-27T08:56:20.000+02:00
This was added in 4bf2e36, but BlockAssembler::CreateNewBlock already locks cs_main internally.
diff --git a/src/node/interfaces.cpp b/src/node/interfaces.cpp
@@ -881,7 +881,6 @@ class MinerImpl : public Mining
         BlockAssembler::Options options;
         ApplyArgsManOptions(gArgs, options);
 
-        LOCK(::cs_main);
         return BlockAssembler{chainman().ActiveChainstate(), use_mempool ? context()->mempool.get() : nullptr, options}.CreateNewBlock(script_pub_key);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -881,7 +881,6 @@ class MinerImpl : public Mining`
`881`	`881`	`BlockAssembler::Options options;`
`882`	`882`	`ApplyArgsManOptions(gArgs, options);`
`883`	`883`
`884`		`- LOCK(::cs_main);`
`885`	`884`	`return BlockAssembler{chainman().ActiveChainstate(), use_mempool ? context()->mempool.get() : nullptr, options}.CreateNewBlock(script_pub_key);`
`886`	`885`	`}`
`887`	`886`