Skip to content

Commit 5da7c0b

Browse files
committed
build: allow libitcoinkernel dll builds now that exports are fixed
Symbol visibility issues are not actually fixed yet because we have not yet defined an api and exported symbols, but everything is now in place for that.
1 parent 130490a commit 5da7c0b

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

src/Makefile.am

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -879,15 +879,6 @@ libbitcoinkernel_la_CPPFLAGS = $(AM_CPPFLAGS) -I$(builddir)/obj -I$(srcdir)/secp
879879
# to export from the library.
880880
libbitcoinkernel_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) -fvisibility=default
881881

882-
# TODO: For now, Specify -static in both CXXFLAGS and LDFLAGS when building for
883-
# windows targets so libtool will only build a static version of this
884-
# library. There are unresolved problems when building dll's for mingw-w64
885-
# and attempting to statically embed libstdc++, libpthread, etc.
886-
if TARGET_WINDOWS
887-
libbitcoinkernel_la_LDFLAGS += -static
888-
libbitcoinkernel_la_CXXFLAGS += -static
889-
endif
890-
891882
# TODO: libbitcoinkernel is a work in progress consensus engine library, as more
892883
# and more modules are decoupled from the consensus engine, this list will
893884
# shrink to only those which are absolutely necessary.

0 commit comments

Comments
 (0)