Skip to content

Commit 59d3e4e

Browse files
committed
Merge bitcoin/bitcoin#32415: scripted-diff: adapt script error constant names in feature_taproot.py
b5f580c scripted-diff: adapt script error constant names in feature_taproot.py (Sebastian Falbesoner) Pull request description: While reviewing #31622 I noticed that the constant name `(SCRIPT_)ERR_SIG_HASHTYPE` is used for two different script verification error codes, namely one for legacy and one for Schnorr signatures: https://github.com/bitcoin/bitcoin/blob/eba5f9c4b63fe46261fbb3e71b9a94832d105b23/src/script/script_error.cpp#L56-L57 https://github.com/bitcoin/bitcoin/blob/eba5f9c4b63fe46261fbb3e71b9a94832d105b23/test/functional/feature_taproot.py#L600 In order to resolve this confusion, this PR adapts all script error constant names in the functional tests (currently only in feature_taproot.py) to the ones used in our C++ codebase (see [script_error.cpp](https://github.com/bitcoin/bitcoin/blob/master/src/script/script_error.cpp)) with a scripted diff. This also makes checking whether we have test coverage for a certain script error easier. ACKs for top commit: jamesob: crACK bitcoin/bitcoin@b5f580c achow101: ACK b5f580c rkrux: tACK b5f580c stratospher: ACK b5f580c. liked the consistency in script error names. Tree-SHA512: bc0ccec70bc3cb6ce51ce8e27a5e54770d1bb93c1db5a9c815caa25f3d96ebb382104bd9b51626f501d4f5b95148db8d20c806a27153e9bb9cf823a20d3046c0
2 parents fffb272 + b5f580c commit 59d3e4e

File tree

1 file changed

+98
-98
lines changed

1 file changed

+98
-98
lines changed

0 commit comments

Comments
 (0)