Skip to content

Commit 5488dc1

Browse files
committed
Merge bitcoin/bitcoin#26073: build: fix depends bdb compilation for BSDs
5b2529b build: fix depends bdb compilation for BSDs (fanquake) Pull request description: Currently, building bdb for *BSD HOSTs in depends fails with: ```bash libtool: compile: clang -m64 -c -I. -I../dist/./.. -I/home/ubuntu/bitcoin/depends/x86_64-unknown-freebsd/include -D_THREAD_SAFE -pipe -std=c11 -O2 -Wno-error=implicit-function-declaration -Wno-error=format-security ../dist/./../mutex/mut_tas.c -fPIC -DPIC -o mut_tas.o In file included from ../dist/./../mutex/mut_tas.c:11: In file included from ./db_int.h:884: In file included from ../dist/./../dbinc/mutex.h:15: ../dist/./../dbinc/mutex_int.h:932:2: error: unknown type name 'pthread_rwlock_t' MUTEX_FIELDS /* Opaque thread mutex structures. */ ^ ../dist/./../dbinc/mutex_int.h:65:3: note: expanded from macro 'MUTEX_FIELDS' pthread_rwlock_t rwlock; /* Read/write lock */ \ ^ 1 error generated. ``` Defining `_XOPEN_SOURCE` >=600 fixes access to the missing `pthread_rwlock_t` definitions. ACKs for top commit: jarolrod: ACK 5b2529b Tree-SHA512: 76584bfef7a86c69a095eb722657aa681b95658a031ef2da79d91a616e5370da292a65e7d67cdf641711791422b8a407b647b630ad497ffb9908683479e6cfb6
2 parents 5939794 + 5b2529b commit 5488dc1

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

depends/packages/bdb.mk

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ $(package)_config_opts_netbsd=--with-pic
1515
$(package)_config_opts_openbsd=--with-pic
1616
$(package)_config_opts_android=--with-pic
1717
$(package)_cflags+=-Wno-error=implicit-function-declaration -Wno-error=format-security
18+
$(package)_cppflags_freebsd=-D_XOPEN_SOURCE=600
19+
$(package)_cppflags_netbsd=-D_XOPEN_SOURCE=600
20+
$(package)_cppflags_openbsd=-D_XOPEN_SOURCE=600
1821
$(package)_cppflags_mingw32=-DUNICODE -D_UNICODE
1922
endef
2023

0 commit comments

Comments
 (0)