Merge bitcoin/bitcoin#27571: ci: Run iwyu on all src files

ddddf49 ci: Run iwyu on all src files (MarcoFalke)

Pull request description:

  This makes it easier to look at the CI output of a file without having to manually add it first to the list.

ACKs for top commit:
  hebasto:
    ACK ddddf49

Tree-SHA512: 342b52838ae45ea343731c30058cdd5595d5ea5601a1f396de4466ccdd63f7ab07b3a193df3669e4dca7cb535557dcc98f866b3cf986b98176b20ecead123868

Author: fanquake

ci/test/00_setup_env_native_tidy.sh

@@ -8,7 +8,7 @@ export LC_ALL=C.UTF-8
 
 export CI_IMAGE_NAME_TAG="ubuntu:lunar" # Version 23.04 will reach EOL in Jan 2024, and can be replaced by "ubuntu:24.04" (or anything else that ships the wanted clang version).
 export CONTAINER_NAME=ci_native_tidy
-export PACKAGES="clang-16 libclang-16-dev llvm-16-dev libomp-16-dev clang-tidy-16 bear cmake libevent-dev libboost-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev systemtap-sdt-dev libqt5gui5 libqt5core5a libqt5dbus5 qttools5-dev qttools5-dev-tools libqrencode-dev libsqlite3-dev libdb++-dev"
+export PACKAGES="clang-16 libclang-16-dev llvm-16-dev libomp-16-dev clang-tidy-16 jq bear cmake libevent-dev libboost-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev systemtap-sdt-dev libqt5gui5 libqt5core5a libqt5dbus5 qttools5-dev qttools5-dev-tools libqrencode-dev libsqlite3-dev libdb++-dev"
 export NO_DEPENDS=1
 export RUN_UNIT_TESTS=false
 export RUN_FUNCTIONAL_TESTS=false

ci/test/06_script_b.sh

@@ -157,51 +157,16 @@ if [ "${RUN_TIDY}" = "true" ]; then
   set -eo pipefail
   cd "${BASE_BUILD_DIR}/bitcoin-$HOST/src/"
   ( run-clang-tidy-16 -quiet "${MAKEJOBS}" ) | grep -C5 "error"
+  # Filter out files by regex here, because regex may not be
+  # accepted in src/.bear-tidy-config
+  # Filter out:
+  # * qt qrc and moc generated files
+  # * walletutil (temporarily)
+  # * secp256k1
+  jq 'map(select(.file | test("src/qt/qrc_.*\\.cpp$|/moc_.*\\.cpp$|src/wallet/walletutil|src/secp256k1/src/") | not))' ../compile_commands.json > tmp.json
+  mv tmp.json ../compile_commands.json
   cd "${BASE_BUILD_DIR}/bitcoin-$HOST/"
   python3 "${DIR_IWYU}/include-what-you-use/iwyu_tool.py" \
-           src/common/args.cpp \
-           src/common/config.cpp \
-           src/common/init.cpp \
-           src/common/url.cpp \
-           src/compat \
-           src/dbwrapper.cpp \
-           src/init \
-           src/kernel \
-           src/node/blockmanager_args.cpp \
-           src/node/chainstate.cpp \
-           src/node/chainstatemanager_args.cpp \
-           src/node/mempool_args.cpp \
-           src/node/minisketchwrapper.cpp \
-           src/node/utxo_snapshot.cpp \
-           src/node/validation_cache_args.cpp \
-           src/policy/feerate.cpp \
-           src/policy/packages.cpp \
-           src/policy/settings.cpp \
-           src/primitives/transaction.cpp \
-           src/random.cpp \
-           src/rpc/fees.cpp \
-           src/rpc/signmessage.cpp \
-           src/test/fuzz/string.cpp \
-           src/test/fuzz/txorphan.cpp \
-           src/test/fuzz/util \
-           src/test/util/coins.cpp \
-           src/uint256.cpp \
-           src/util/bip32.cpp \
-           src/util/bytevectorhash.cpp \
-           src/util/check.cpp \
-           src/util/error.cpp \
-           src/util/exception.cpp \
-           src/util/getuniquepath.cpp \
-           src/util/hasher.cpp \
-           src/util/message.cpp \
-           src/util/moneystr.cpp \
-           src/util/serfloat.cpp \
-           src/util/spanparsing.cpp \
-           src/util/strencodings.cpp \
-           src/util/string.cpp \
-           src/util/syserror.cpp \
-           src/util/threadinterrupt.cpp \
-           src/zmq \
            -p . "${MAKEJOBS}" \
            -- -Xiwyu --cxx17ns -Xiwyu --mapping_file="${BASE_BUILD_DIR}/bitcoin-$HOST/contrib/devtools/iwyu/bitcoin.core.imp" \
            2>&1 | tee /tmp/iwyu_ci.out