Skip to content

Commit 49cf635

Browse files
committed
qt, test: Set organization name
If `setOrganizationName()` and `setApplicationName()` has not been previously called, the `QSettings` object will not be able to read or write any settings.
1 parent 98005b6 commit 49cf635

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

src/qt/test/optiontests.cpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,17 @@ void OptionTests::migrateSettings()
5050

5151
settings.sync();
5252

53+
QVERIFY(settings.contains("nDatabaseCache"));
54+
QVERIFY(settings.contains("nThreadsScriptVerif"));
55+
QVERIFY(settings.contains("fUseUPnP"));
56+
QVERIFY(settings.contains("fListen"));
57+
QVERIFY(settings.contains("bPrune"));
58+
QVERIFY(settings.contains("nPruneSize"));
59+
QVERIFY(settings.contains("fUseProxy"));
60+
QVERIFY(settings.contains("addrProxy"));
61+
QVERIFY(settings.contains("fUseSeparateProxyTor"));
62+
QVERIFY(settings.contains("addrSeparateProxyTor"));
63+
5364
OptionsModel options{m_node};
5465
bilingual_str error;
5566
QVERIFY(options.Init(error));

src/qt/test/test_main.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include <interfaces/init.h>
1010
#include <interfaces/node.h>
1111
#include <qt/bitcoin.h>
12+
#include <qt/guiconstants.h>
1213
#include <qt/test/apptests.h>
1314
#include <qt/test/optiontests.h>
1415
#include <qt/test/rpcnestedtests.h>
@@ -24,6 +25,7 @@
2425
#include <QApplication>
2526
#include <QDebug>
2627
#include <QObject>
28+
#include <QSettings>
2729
#include <QTest>
2830

2931
#include <functional>
@@ -84,7 +86,8 @@ int main(int argc, char* argv[])
8486
#endif
8587

8688
BitcoinApplication app;
87-
app.setApplicationName("Bitcoin-Qt-test");
89+
app.setOrganizationName(QAPP_ORG_NAME);
90+
app.setApplicationName(QAPP_APP_NAME_DEFAULT "-test");
8891
app.createNode(*init);
8992

9093
int num_test_failures{0};

0 commit comments

Comments
 (0)