You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1b22849 qt: Drop no longer used `SplashScreen::finish()` slot (Hennadii Stepanov)
10811af qt: Drop no longer used `BitcoinApplication::splashFinished()` signal (Hennadii Stepanov)
5299cfe qt: Delete splash screen widget explicitly (Hennadii Stepanov)
Pull request description:
Fixes#604.
Fixesbitcoin/bitcoin#25146.
Fixesbitcoin/bitcoin#26340.
`SplashScreen::deleteLater()` [does not guarantee](https://doc.qt.io/qt-5/qobject.html#deleteLater) deletion of the `m_splash` object prior to the wallet context deletion. If the latter happens first, the [segfault](#604 (comment)) follows.
ACKs for top commit:
dooglus:
ACK 1b22849
furszy:
ACK 1b22849
john-moffett:
ACK 1b22849
Tree-SHA512: bb01d0bf2051f5b184dc415c4f5d32dfb7b8bd772feff7ec7754ded4c6482de27f004b9712df7d53c5ee82e153f48aef4372e4a49d7bcbbb137f73e9b4947962
0 commit comments