Merge bitcoin/bitcoin#30172: fuzz: Handle missing BDBRO errors

9ddf39d fuzz: Handle missing BDBRO errors (Ava Chow)

Pull request description:

  Adds error messages that were not being handled. Also removes error messages that no longer exist.

  Fixes #30166

ACKs for top commit:
  dergoegge:
    reACK 9ddf39d
  TheCharlatan:
    ACK 9ddf39d

Tree-SHA512: 2597536a1e5d030653dfcb02fd892f7492f5a091def787f6cbd421b8bca9544847684a498e9458ea99ae7de5a8a6d91532ff904d1e39222d324939d31d2eb3f0

Author: fanquake

src/wallet/test/fuzz/wallet_bdb_parser.cpp

@@ -52,7 +52,7 @@ FUZZ_TARGET(wallet_bdb_parser, .init = initialize_wallet_bdb_parser)
 
 #ifdef USE_BDB
     bool bdb_ro_err = false;
-    bool bdb_ro_pgno_err = false;
+    bool bdb_ro_strict_err = false;
 #endif
     auto db{MakeBerkeleyRODatabase(wallet_path, options, status, error)};
     if (db) {
@@ -64,30 +64,33 @@ FUZZ_TARGET(wallet_bdb_parser, .init = initialize_wallet_bdb_parser)
         if (error.original.starts_with("AutoFile::ignore: end of file") ||
             error.original.starts_with("AutoFile::read: end of file") ||
             error.original == "Not a BDB file" ||
-            error.original == "Unsupported BDB data file version number" ||
             error.original == "Unexpected page type, should be 9 (BTree Metadata)" ||
             error.original == "Unexpected database flags, should only be 0x20 (subdatabases)" ||
             error.original == "Unexpected outer database root page type" ||
             error.original == "Unexpected number of entries in outer database root page" ||
-            error.original == "Subdatabase has an unexpected name" ||
             error.original == "Subdatabase page number has unexpected length" ||
-            error.original == "Unexpected inner database page type" ||
             error.original == "Unknown record type in records page" ||
             error.original == "Unknown record type in internal page" ||
             error.original == "Unexpected page size" ||
             error.original == "Unexpected page type" ||
             error.original == "Page number mismatch" ||
             error.original == "Bad btree level" ||
             error.original == "Bad page size" ||
-            error.original == "File size is not a multiple of page size" ||
-            error.original == "Meta page number mismatch") {
+            error.original == "Meta page number mismatch" ||
+            error.original == "Data record position not in page" ||
+            error.original == "Internal record position not in page" ||
+            error.original == "LSNs are not reset, this database is not completely flushed. Please reopen then close the database with a version that has BDB support" ||
+            error.original == "Records page has odd number of records" ||
+            error.original == "Bad overflow record page type") {
             // Do nothing
         } else if (error.original == "Subdatabase last page is greater than database last page" ||
                    error.original == "Page number is greater than database last page" ||
-                   error.original == "Page number is greater than subdatabase last page" ||
-                   error.original == "Last page number could not fit in file") {
+                   error.original == "Last page number could not fit in file" ||
+                   error.original == "Subdatabase has an unexpected name" ||
+                   error.original == "Unsupported BDB data file version number" ||
+                   error.original == "BDB builtin encryption is not supported") {
 #ifdef USE_BDB
-            bdb_ro_pgno_err = true;
+            bdb_ro_strict_err = true;
 #endif
         } else {
             throw std::runtime_error(error.original);
@@ -108,9 +111,8 @@ FUZZ_TARGET(wallet_bdb_parser, .init = initialize_wallet_bdb_parser)
             return;
         }
         assert(db);
-        if (bdb_ro_pgno_err) {
-            // BerkeleyRO will throw on opening for errors involving bad page numbers, but BDB does not.
-            // Ignore those.
+        if (bdb_ro_strict_err) {
+            // BerkeleyRO will be stricter than BDB. Ignore when those specific errors are hit.
             return;
         }
         assert(!bdb_ro_err);