You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
5b7ed46 cmake: Allow `WITH_DBUS` on all Unix-like systems (Hennadii Stepanov)
Pull request description:
This PR makes the `WITH_DBUS` option available on all Unix-like systems, not just Linux, thereby fixing a regression that was overlooked during the migration from Autotools.
Note: Enabling D-Bus support on macOS still makes no sense, since the `Notificator` class uses the User Notification Center regardless:https://github.com/bitcoin/bitcoin/blob/746ab19d5a13c98ae7492f9b6fb7bd6a2103c65d/src/qt/notificator.cpp#L43-L56Fixesbitcoin/bitcoin#32464.
ACKs for top commit:
laanwj:
ACK 5b7ed46
theStack:
tACK 5b7ed46
Tree-SHA512: 01f5a365a8109c273489e2d46b08d8b64b82251c4814a486561221b55d8a47cb1effc9140dbd6b2ab5f12e2966d0ea0d07a4cbf67d310001ee681b0f5b63f300
Copy file name to clipboardExpand all lines: CMakeLists.txt
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -138,7 +138,7 @@ if(WITH_QRENCODE)
138
138
set(USE_QRCODETRUE)
139
139
endif()
140
140
141
-
cmake_dependent_option(WITH_DBUS"Enable DBus support."ON"CMAKE_SYSTEM_NAME STREQUAL\"Linux\" AND BUILD_GUI"OFF)
141
+
cmake_dependent_option(WITH_DBUS"Enable DBus support."ON"NOT CMAKE_SYSTEM_NAME MATCHES\"(Windows|Darwin)\" AND BUILD_GUI"OFF)
142
142
143
143
option(ENABLE_IPC"Build multiprocess bitcoin-node and bitcoin-gui executables in addition to monolithic bitcoind and bitcoin-qt executables. Requires libmultiprocess library. Experimental."OFF)
144
144
cmake_dependent_option(WITH_EXTERNAL_LIBMULTIPROCESS"Build with external libmultiprocess library instead of with local git subtree when ENABLE_IPC is enabled. This is not normally recommended, but can be useful for developing libmultiprocess itself."OFF"ENABLE_IPC"OFF)
0 commit comments