Skip to content

Commit 3cbc8cb

Browse files
committed
Merge bitcoin/bitcoin#28037: rpc: Drop migratewallet experimental warning
f1684bb rpc: mention that migratewallet can take a while (Andrew Chow) 9ecff99 rpc: Drop migratewallet experimental warning (Andrew Chow) Pull request description: The migration process itself hasn't fundamentally changed since it was added, so I think it's reasonable to say that it is no longer experimental. ACKs for top commit: maflcko: lgtm ACK f1684bb josibake: ACK bitcoin/bitcoin@f1684bb furszy: ACK bitcoin/bitcoin@f1684bb ryanofsky: Code review ACK f1684bb willcl-ark: ACK f1684bb Tree-SHA512: 99b176cddbf3878c76bd4c80c030106200bf03139785e26dbae3341e1a675b623a13cd6dc7a0bb78344335bf859ae7548d97b2b58eb650c6e7b305d7cdc86e40
2 parents dfff8ee + f1684bb commit 3cbc8cb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/wallet/rpc/wallet.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -748,13 +748,13 @@ RPCHelpMan simulaterawtransaction()
748748
static RPCHelpMan migratewallet()
749749
{
750750
return RPCHelpMan{"migratewallet",
751-
"EXPERIMENTAL warning: This call may not work as expected and may be changed in future releases\n"
752751
"\nMigrate the wallet to a descriptor wallet.\n"
753752
"A new wallet backup will need to be made.\n"
754753
"\nThe migration process will create a backup of the wallet before migrating. This backup\n"
755754
"file will be named <wallet name>-<timestamp>.legacy.bak and can be found in the directory\n"
756755
"for this wallet. In the event of an incorrect migration, the backup can be restored using restorewallet."
757-
"\nEncrypted wallets must have the passphrase provided as an argument to this call.",
756+
"\nEncrypted wallets must have the passphrase provided as an argument to this call.\n"
757+
"\nThis RPC may take a long time to complete. Increasing the RPC client timeout is recommended.",
758758
{
759759
{"wallet_name", RPCArg::Type::STR, RPCArg::DefaultHint{"the wallet name from the RPC endpoint"}, "The name of the wallet to migrate. If provided both here and in the RPC endpoint, the two must be identical."},
760760
{"passphrase", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The wallet passphrase"},

0 commit comments

Comments
 (0)