Skip to content

Commit 33d40a6

Browse files
committed
Merge bitcoin/bitcoin#32282: torcontrol: Fix addrOnion outdated comment
bcaa23a torcontrol: Fix addrOnion outdate comment (Eval EXEC) Pull request description: `m_randomize_credentials` is outdated name, remove it. Ref: bitcoin/bitcoin#32176 (comment) ACKs for top commit: achow101: ACK bcaa23a laanwj: ACK bcaa23a w0xlt: ACK bitcoin/bitcoin@bcaa23a jonatack: ACK bcaa23a Tree-SHA512: 38ba9b37e560598605077da7a84c455aa1a7e49365c417ceceff85a18de2af393b164cc8c93cdd6da9eac4d41f046f0ed12bc0f6833fe606c412ce7f1fce5189
2 parents c7b592f + bcaa23a commit 33d40a6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/torcontrol.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -404,9 +404,9 @@ void TorController::get_socks_cb(TorControlConnection& _conn, const TorControlRe
404404
Assume(resolved.IsValid());
405405
LogDebug(BCLog::TOR, "Configuring onion proxy for %s\n", resolved.ToStringAddrPort());
406406

407-
// With m_randomize_credentials = true, generates unique SOCKS credentials per proxy connection (e.g., Tor).
408-
// Prevents connection correlation and enhances privacy by forcing different Tor circuits.
409-
// Requires Tor's IsolateSOCKSAuth (default enabled) for effective isolation (see IsolateSOCKSAuth section in https://2019.www.torproject.org/docs/tor-manual.html.en).
407+
// Add Tor as proxy for .onion addresses.
408+
// Enable stream isolation to prevent connection correlation and enhance privacy, by forcing a different Tor circuit for every connection.
409+
// For this to work, the IsolateSOCKSAuth flag must be enabled on SOCKSPort (which is the default, see the IsolateSOCKSAuth section of Tor's manual page).
410410
Proxy addrOnion = Proxy(resolved, /*tor_stream_isolation=*/ true);
411411
SetProxy(NET_ONION, addrOnion);
412412

0 commit comments

Comments
 (0)