Skip to content

Commit 3310a96

Browse files
committed
Merge bitcoin/bitcoin#29850: net: Decrease nMaxIPs when learning from DNS seeds
f2e3662 net: Decrease nMaxIPs when learning from DNS seeds (laanwj) Pull request description: Limit number of IPs learned from a single DNS seed to 32, to prevent the results from one DNS seed from dominating AddrMan. Note that the number of results from a UDP DNS query is bounded to 33 already, but it is possible for it to use TCP where a larger number of results can be returned. Closes #16070. ACKs for top commit: Sjors: utACK f2e3662 achow101: ACK f2e3662 1440000bytes: utACK bitcoin/bitcoin@f2e3662 mzumsande: utACK f2e3662 Tree-SHA512: 3f108c2baba7adfedb8019daaf60aa00e628b38d3942e1319c7183a4683670be01929ced9e6372c8e983c902e8633f81fbef12d7cdcaadd7f77ed729c1019942
2 parents b3106be + f2e3662 commit 3310a96

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/net.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2256,7 +2256,11 @@ void CConnman::ThreadDNSAddressSeed()
22562256
if (!resolveSource.SetInternal(host)) {
22572257
continue;
22582258
}
2259-
unsigned int nMaxIPs = 256; // Limits number of IPs learned from a DNS seed
2259+
// Limit number of IPs learned from a single DNS seed. This limit exists to prevent the results from
2260+
// one DNS seed from dominating AddrMan. Note that the number of results from a UDP DNS query is
2261+
// bounded to 33 already, but it is possible for it to use TCP where a larger number of results can be
2262+
// returned.
2263+
unsigned int nMaxIPs = 32;
22602264
const auto addresses{LookupHost(host, nMaxIPs, true)};
22612265
if (!addresses.empty()) {
22622266
for (const CNetAddr& ip : addresses) {

0 commit comments

Comments
 (0)