refactor: use CHECK_NONFATAL to avoid single-use symbol

Sjors · Sjors · commit 323cfed5959b · 2024-07-16T09:55:17.000+02:00
diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp
@@ -778,9 +778,7 @@ static RPCHelpMan getblocktemplate()
         }
         ENTER_CRITICAL_SECTION(cs_main);
 
-        std::optional<uint256> maybe_tip{miner.getTipHash()};
-        CHECK_NONFATAL(maybe_tip);
-        tip = maybe_tip.value();
+        tip = CHECK_NONFATAL(miner.getTipHash()).value();
 
         if (!IsRPCRunning())
             throw JSONRPCError(RPC_CLIENT_NOT_CONNECTED, "Shutting down");

Original file line number	Diff line number	Diff line change
`@@ -778,9 +778,7 @@ static RPCHelpMan getblocktemplate()`
`778`	`778`	`}`
`779`	`779`	`ENTER_CRITICAL_SECTION(cs_main);`
`780`	`780`
`781`		`- std::optional<uint256> maybe_tip{miner.getTipHash()};`
`782`		`- CHECK_NONFATAL(maybe_tip);`
`783`		`- tip = maybe_tip.value();`
	`781`	`+ tip = CHECK_NONFATAL(miner.getTipHash()).value();`
`784`	`782`
`785`	`783`	`if (!IsRPCRunning())`
`786`	`784`	`throw JSONRPCError(RPC_CLIENT_NOT_CONNECTED, "Shutting down");`