Skip to content

Commit 2401a24

Browse files
committed
Merge bitcoin/bitcoin#30452: guix: bump time-machine to efc26826400762207cde9f23802cfe75a737963c
6ee000e guix: bump time-machine to efc26826400762207cde9f23802cfe75a737963c (fanquake) cbeb2c2 guix: patch /gnu/store paths out of winpthreads (fanquake) Pull request description: Needed for bitcoin/bitcoin#30210. This doesn't switch runtimes, because upstream is still configured to use the old runtime. See: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=17188be0f723e00377b21b767f5447d7938a116e. git-mimimal `2.45.1` -> `2.45.2` Kernel Headers `6.1.92` -> `6.1.100` LLVM `18.1.6` -> `18.1.8` mingw-w64 `11.0.1` -> `12.0.0` NSIS `3.09` -> `3.10` patch `2.7.6` -> `2.7.6-0.f144b35` ACKs for top commit: TheCharlatan: ACK 6ee000e Tree-SHA512: f4f99d16dd8cab5b2b7c5d82111af86de20e1669cc3b4054d72ab4a67b2956757df170f0df28c96d18653c1c9d2ebdd0ecc441005726a20cd963d98513b4a851
2 parents d367a4e + 6ee000e commit 2401a24

File tree

5 files changed

+30
-14
lines changed

5 files changed

+30
-14
lines changed

contrib/devtools/symbol-check.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ def check_MACHO_sdk(binary) -> bool:
245245
return False
246246

247247
def check_MACHO_lld(binary) -> bool:
248-
if binary.build_version.tools[0].version == [18, 1, 6]:
248+
if binary.build_version.tools[0].version == [18, 1, 8]:
249249
return True
250250
return False
251251

contrib/guix/libexec/prelude.bash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ fi
5151
time-machine() {
5252
# shellcheck disable=SC2086
5353
guix time-machine --url=https://git.savannah.gnu.org/git/guix.git \
54-
--commit=f0bb724211872cd6158fce6162e0b8c73efed126 \
54+
--commit=efc26826400762207cde9f23802cfe75a737963c \
5555
--cores="$JOBS" \
5656
--keep-failed \
5757
--fallback \

contrib/guix/manifest.scm

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,17 @@ desirable for building Bitcoin Core release binaries."
128128
(package-with-extra-patches binutils
129129
(search-our-patches "binutils-unaligned-default.patch")))
130130

131+
(define (winpthreads-patches mingw-w64-x86_64-winpthreads)
132+
(package-with-extra-patches mingw-w64-x86_64-winpthreads
133+
(search-our-patches "winpthreads-remap-guix-store.patch")))
134+
131135
(define (make-mingw-pthreads-cross-toolchain target)
132136
"Create a cross-compilation toolchain package for TARGET"
133137
(let* ((xbinutils (binutils-mingw-patches (cross-binutils target)))
134138
(machine (substring target 0 (string-index target #\-)))
135-
(pthreads-xlibc (make-mingw-w64 machine
139+
(pthreads-xlibc (winpthreads-patches (make-mingw-w64 machine
136140
#:xgcc (cross-gcc target #:xgcc (gcc-mingw-patches base-gcc))
137-
#:with-winpthreads? #t))
141+
#:with-winpthreads? #t)))
138142
(pthreads-xgcc (cross-gcc target
139143
#:xgcc (gcc-mingw-patches mingw-w64-base-gcc)
140144
#:xbinutils xbinutils

contrib/guix/patches/gcc-remap-guix-store.patch

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
1-
From aad25427e74f387412e8bc9a9d7bbc6c496c792f Mon Sep 17 00:00:00 2001
2-
From: Andrew Chow <achow101-github@achow101.com>
3-
Date: Wed, 6 Jul 2022 16:49:41 -0400
4-
Subject: [PATCH] guix: remap guix store paths to /usr
1+
Without ffile-prefix-map, the debug symbols will contain paths for the
2+
guix store which will include the hashes of each package. However, the
3+
hash for the same package will differ when on different architectures.
4+
In order to be reproducible regardless of the architecture used to build
5+
the package, map all guix store prefixes to something fixed, e.g. /usr.
56

6-
---
7-
libgcc/Makefile.in | 2 +-
8-
1 file changed, 1 insertion(+), 1 deletion(-)
9-
10-
diff --git a/libgcc/Makefile.in b/libgcc/Makefile.in
11-
index 851e7657d07..476c2becd1c 100644
127
--- a/libgcc/Makefile.in
138
+++ b/libgcc/Makefile.in
149
@@ -854,7 +854,7 @@ endif
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
Without ffile-prefix-map, the debug symbols will contain paths for the
2+
guix store which will include the hashes of each package. However, the
3+
hash for the same package will differ when on different architectures.
4+
In order to be reproducible regardless of the architecture used to build
5+
the package, map all guix store prefixes to something fixed, e.g. /usr.
6+
7+
--- a/mingw-w64-libraries/winpthreads/Makefile.in
8+
+++ b/mingw-w64-libraries/winpthreads/Makefile.in
9+
@@ -478,7 +478,7 @@ top_build_prefix = @top_build_prefix@
10+
top_builddir = @top_builddir@
11+
top_srcdir = @top_srcdir@
12+
SUBDIRS = . tests
13+
-AM_CFLAGS = -Wall -DWIN32_LEAN_AND_MEAN $(am__append_1)
14+
+AM_CFLAGS = -Wall -DWIN32_LEAN_AND_MEAN $(am__append_1) $(shell find /gnu/store -maxdepth 1 -mindepth 1 -type d -exec echo -n " -ffile-prefix-map={}=/usr" \;)
15+
ACLOCAL_AMFLAGS = -I m4
16+
lib_LTLIBRARIES = libwinpthread.la
17+
include_HEADERS = include/pthread.h include/sched.h include/semaphore.h include/pthread_unistd.h include/pthread_time.h include/pthread_compat.h include/pthread_signal.h

0 commit comments

Comments
 (0)