Skip to content

Commit 188b021

Browse files
committed
Merge bitcoin/bitcoin#31635: test: add coverage for unknown address type for createwalletdescriptor
4da7bfd test: add coverage for unknown address type for `createwalletdescriptor` (brunoerg) Pull request description: Calling `createwalletdescriptor` RPC with an unknown address type throws an error. This PR adds test coverage for it as done for other RPCs (`getnewaddress `, `getrawchangeaddress`, etc). ACKs for top commit: maflcko: lgtm ACK 4da7bfd rkrux: tACK 4da7bfd Tree-SHA512: 490bc3ffeb70b0f26db0a44d3950d7410fef35d4056487f2e82c081fb14ca277a18943c487235e0163a29f90fc741a262c29835beb9f41936affa4e73ddad25f
2 parents 2317e6c + 4da7bfd commit 188b021

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

test/functional/wallet_address_types.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,8 @@ def run_test(self):
369369
assert_raises_rpc_error(-5, "Unknown address type ''", self.nodes[3].getnewaddress, None, '')
370370
assert_raises_rpc_error(-5, "Unknown address type ''", self.nodes[3].getrawchangeaddress, '')
371371
assert_raises_rpc_error(-5, "Unknown address type 'bech23'", self.nodes[3].getrawchangeaddress, 'bech23')
372+
if self.options.descriptors:
373+
assert_raises_rpc_error(-5, "Unknown address type 'bech23'", self.nodes[3].createwalletdescriptor, "bech23")
372374

373375
self.log.info("Nodes with changetype=p2sh-segwit never use a P2WPKH change output")
374376
self.test_change_output_type(4, [to_address_bech32_1], 'p2sh-segwit')

0 commit comments

Comments
 (0)