Merge bitcoin/bitcoin#30374: Revert "test: p2p: check that connecting to ourself leads to disconnect"

9ec2c53 Revert "test: p2p: check that connecting to ourself leads to disconnect" (Sebastian Falbesoner)

Pull request description:

  As suggested in bitcoin/bitcoin#30368 (comment), this PR reverts the recently  added test  #30362 that causes frequent CI failures. A TODO is added in the functional test file to re-add it later when the race condition is fixed.

ACKs for top commit:
  mzumsande:
    utACK 9ec2c53
  brunoerg:
    utACK 9ec2c53
  tdb3:
    ACK 9ec2c53

Tree-SHA512: df211ab194dc47f2ff8192f3827382974db922ed9fa54bc44fac75de4edfb3af43c1340cd5434b15b0b573f7b0ddd4451a0bbbbd7deaf7f4244e4865b9d5977e

Author: fanquake

test/functional/p2p_handshake.py

@@ -17,7 +17,6 @@
     NODE_WITNESS,
 )
 from test_framework.p2p import P2PInterface
-from test_framework.util import p2p_port
 
 
 # Desirable service flags for outbound non-pruned and pruned peers. Note that
@@ -89,11 +88,9 @@ def run_test(self):
         with node.assert_debug_log([f"feeler connection completed"]):
             self.add_outbound_connection(node, "feeler", NODE_NONE, wait_for_disconnect=True)
 
-        self.log.info("Check that connecting to ourself leads to immediate disconnect")
-        with node.assert_debug_log(["connected to self", "disconnecting"]):
-            node_listen_addr = f"127.0.0.1:{p2p_port(0)}"
-            node.addconnection(node_listen_addr, "outbound-full-relay", self.options.v2transport)
-        self.wait_until(lambda: len(node.getpeerinfo()) == 0)
+        # TODO: re-add test introduced in commit 5d2fb14bafe4e80c0a482d99e5ebde07c477f000
+        # ("test: p2p: check that connecting to ourself leads to disconnect") once
+        # the race condition causing issue #30368 is fixed
 
 
 if __name__ == '__main__':