Skip to content

Commit fde1c2f

Browse files
jarolrodhebasto
authored andcommitted
qml, doc: Refer to CI assets as unsecure, instead of insecure
1 parent 380e74c commit fde1c2f

File tree

3 files changed

+24
-24
lines changed

3 files changed

+24
-24
lines changed

.cirrus.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,9 @@ task:
215215
env:
216216
<< : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV
217217
copy_artifacts_script:
218-
- cp ci/scratch/build/bitcoin-x86_64-w64-mingw32/release/bitcoin-qt.exe insecure_win_gui.exe
219-
insecure_win_gui_artifacts:
220-
path: "insecure_win_gui.exe"
218+
- cp ci/scratch/build/bitcoin-x86_64-w64-mingw32/release/bitcoin-qt.exe unsecure_win_gui.exe
219+
unsecure_win_gui_artifacts:
220+
path: "unsecure_win_gui.exe"
221221

222222
task:
223223
name: '32-bit + dash [gui] [CentOS 8]'
@@ -336,10 +336,10 @@ task:
336336
MACOS_SDK: "Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers"
337337
<< : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV
338338
copy_artifacts_script:
339-
- cp ci/scratch/build/bitcoin-x86_64-apple-darwin/src/qt/bitcoin-qt insecure_mac_gui
340-
- tar -czf insecure_mac_gui.tar.gz insecure_mac_gui
341-
insecure_mac_gui_artifacts:
342-
path: "insecure_mac_gui.tar.gz"
339+
- cp ci/scratch/build/bitcoin-x86_64-apple-darwin/src/qt/bitcoin-qt unsecure_mac_gui
340+
- tar -czf unsecure_mac_gui.tar.gz unsecure_mac_gui
341+
unsecure_mac_gui_artifacts:
342+
path: "unsecure_mac_gui.tar.gz"
343343
type: "application/gzip"
344344

345345
task:
@@ -359,10 +359,10 @@ task:
359359
MACOS_SDK: "Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers"
360360
<< : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV
361361
copy_artifacts_script:
362-
- cp ci/scratch/build/bitcoin-arm64-apple-darwin/src/qt/bitcoin-qt insecure_mac_arm64_gui
363-
- tar -czf insecure_mac_arm64_gui.tar.gz insecure_mac_arm64_gui
364-
insecure_mac_arm64_gui_artifacts:
365-
path: "insecure_mac_arm64_gui.tar.gz"
362+
- cp ci/scratch/build/bitcoin-arm64-apple-darwin/src/qt/bitcoin-qt unsecure_mac_arm64_gui
363+
- tar -czf unsecure_mac_arm64_gui.tar.gz unsecure_mac_arm64_gui
364+
unsecure_mac_arm64_gui_artifacts:
365+
path: "unsecure_mac_arm64_gui.tar.gz"
366366
type: "application/gzip"
367367

368368
task:
@@ -401,6 +401,6 @@ task:
401401
env:
402402
<< : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV
403403
copy_artifacts_script:
404-
- cp src/qt/android/build/outputs/apk/debug/android-debug.apk ${CIRRUS_WORKING_DIR}/insecure_android.apk
405-
insecure_android_apk_artifacts:
406-
path: "insecure_android.apk"
404+
- cp src/qt/android/build/outputs/apk/debug/android-debug.apk ${CIRRUS_WORKING_DIR}/unsecure_android.apk
405+
unsecure_android_apk_artifacts:
406+
path: "unsecure_android.apk"

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ patches often sit for a long time.
4545
<!--
4646
Links for Windows and macOS build artifacts. Replace <PR> with the assigned pull request number.
4747
48-
[![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/<PR>)
49-
[![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/<PR>)
50-
[![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/<PR>)
51-
[![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/<PR>)
48+
[![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/<PR>)
49+
[![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/<PR>)
50+
[![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/<PR>)
51+
[![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/<PR>)
5252
-->

src/qml/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44

55
This directory contains the source code for an experimental Bitcoin Core graphical user interface (GUI) built using the [Qt Quick](https://doc.qt.io/qt-5/qtquick-index.html) framework.
66

7-
Insecure CI artifacts are available for local testing of the master branch, avoiding the need to build:
8-
- for Windows: [`insecure_win_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip)
9-
- for Intel macOS: [`insecure_mac_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip)
10-
- for Apple Silicon macOS: [`insecure_mac_arm64_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip)
11-
- for ARM64 Android: [`insecure_android_apk.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip)
7+
Unsecure CI artifacts are available for local testing of the master branch, avoiding the need to build:
8+
- for Windows: [`unsecure_win_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip)
9+
- for Intel macOS: [`unsecure_mac_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip)
10+
- for Apple Silicon macOS: [`unsecure_mac_arm64_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip)
11+
- for ARM64 Android: [`unsecure_android_apk.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip)
1212

1313
Note: For Apple Silicon macOS machines, the binary must be signed before it can
1414
be ran. To apply a signature, run the following on the unzipped CI artifact:
1515

1616
```
17-
codesign -s - ./Downloads/insecure_mac_arm64_gui
17+
codesign -s - ./Downloads/unsecure_mac_arm64_gui
1818
```
1919

2020
## Goals and Limitations

0 commit comments

Comments
 (0)