Skip to content

Commit ae512b8

Browse files
committed
Merge #327: Fix width/height binding loop in Network Traffic page
2eace14 qml: fix width/height binding loop in Network Traffic page (jarolrod) Pull request description: Fixes #323 [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/327) [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/327) [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/327) [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/327) ACKs for top commit: johnny9: ACK 2eace14 hebasto: ACK 2eace14, tested on Ubuntu 23.04 (Qt 5.15.8). Tree-SHA512: c75606a0e61249f8c24dd0a1fa49abcf1353fadbe870959517e56969baad339e38362d4c84bc8d584aa36895ea8d357d8f227897efd3760df9fa84a38a22570c
2 parents 810fa55 + 2eace14 commit ae512b8

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/qml/pages/node/NetworkTraffic.qml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,16 @@ InformationPage {
2828
Rectangle {
2929
Layout.alignment: Qt.AlignHCenter
3030
color: Theme.color.neutral3
31-
width: childrenRect.width + 6
32-
height: childrenRect.height + 6
31+
width: scaleRow.implicitWidth + 6
32+
height: scaleRow.implicitHeight + 6
3333
radius: 3
3434

3535
Behavior on color {
3636
ColorAnimation { duration: 150 }
3737
}
3838

3939
RowLayout {
40+
id: scaleRow
4041
anchors.centerIn: parent
4142
anchors.margins: 3
4243
spacing: 5

0 commit comments

Comments
 (0)