qml: entangle the About and Developer options pages

Currently, the parent SwipeView of the AboutOptions page needs to have
an id of introductions. We abuse the knowledge that in our codebase we
will have that available, but this limits when and where the
AboutOptions can be used. This entangles the About and Developer options
so that we can avoid this, and have these pages truly be reusable.

Github-Pull: #203
Rebased-From: 6ac40e8

Co-Authored-By: Johnny Carlson <johncarlson@pm.me>

Author: 2 people

src/qml/BitcoinApp/Components/AboutOptions.qml

@@ -56,7 +56,7 @@ ColumnLayout {
             icon.width: 18
             background: null
             onClicked: {
-                introductions.incrementCurrentIndex()
+                aboutSwipe.incrementCurrentIndex()
             }
         }
     }

src/qml/BitcoinApp/OnboardingCover.qml

@@ -51,14 +51,5 @@ Page {
                 }
             }
         }
-        SettingsDeveloper {
-            navLeftDetail: NavButton {
-                iconSource: "image://images/caret-left"
-                text: qsTr("Back")
-                onClicked: {
-                    introductions.decrementCurrentIndex()
-                }
-            }
-        }
     }
 }

src/qml/BitcoinApp/SettingsAbout.qml

@@ -8,19 +8,40 @@ import QtQuick.Layouts
 import BitcoinApp.Controls
 import BitcoinApp.Components
 
-InformationPage {
-    bannerActive: false
-    bold: true
-    headerText: qsTr("About")
-    headerMargin: 0
-    description: qsTr("Bitcoin Core is an open source project.\nIf you find it useful, please contribute.\n\n This is experimental software.")
-    descriptionMargin: 20
-    detailActive: true
-    detailItem: ColumnLayout {
-        spacing: 0
-        AboutOptions {
-            Layout.maximumWidth: 450
-            Layout.alignment: Qt.AlignCenter
+Item {
+    property alias navLeftDetail: aboutSwipe.navLeftDetail
+    SwipeView {
+        id: aboutSwipe
+        property alias navLeftDetail: about_settings.navLeftDetail
+        anchors.fill: parent
+        interactive: false
+        orientation: Qt.Horizontal
+        InformationPage {
+            id: about_settings
+            bannerActive: false
+            bannerMargin: 0
+            bold: true
+            headerText: qsTr("About")
+            headerMargin: 0
+            description: qsTr("Bitcoin Core is an open source project.\nIf you find it useful, please contribute.\n\n This is experimental software.")
+            descriptionMargin: 20
+            detailActive: true
+            detailItem: ColumnLayout {
+                spacing: 0
+                AboutOptions {
+                    Layout.maximumWidth: 450
+                    Layout.alignment: Qt.AlignCenter
+                }
+            }
+        }
+        SettingsDeveloper {
+            navLeftDetail: NavButton {
+                iconSource: "image://images/caret-left"
+                text: qsTr("Back")
+                onClicked: {
+                    aboutSwipe.decrementCurrentIndex()
+                }
+            }
         }
     }
 }