qml: make external links follow the specs in the design file

Author: jarolrod

src/qml/components/AboutOptions.qml

@@ -17,7 +17,6 @@ ColumnLayout {
             parentState: websiteLink.state
             description: "bitcoincore.org"
             link: "https://bitcoincore.org"
-            iconSource: "image://images/caret-right"
         }
         onClicked: loadedItem.clicked()
     }
@@ -29,7 +28,6 @@ ColumnLayout {
             parentState: sourceLink.state
             description: "github.com/bitcoin/bitcoin"
             link: "https://github.com/bitcoin/bitcoin"
-            iconSource: "image://images/caret-right"
         }
         onClicked: loadedItem.clicked()
     }
@@ -41,7 +39,6 @@ ColumnLayout {
             parentState: licenseLink.state
             description: "MIT"
             link: "https://opensource.org/licenses/MIT"
-            iconSource: "image://images/caret-right"
         }
         onClicked: loadedItem.clicked()
     }
@@ -54,6 +51,8 @@ ColumnLayout {
             description: "v22.99.0-1e7564eca8a6"
             link: "https://bitcoin.org/en/download"
             iconSource: "image://images/caret-right"
+            iconWidth: 18
+            iconHeight: 18
         }
         onClicked: loadedItem.clicked()
     }

src/qml/controls/ExternalLink.qml

@@ -12,9 +12,9 @@ AbstractButton {
     required property string link
     property string description: ""
     property int descriptionSize: 18
-    property url iconSource: ""
-    property int iconWidth: 18
-    property int iconHeight: 18
+    property url iconSource: "image://images/export"
+    property int iconWidth: 22
+    property int iconHeight: 22
     property color iconColor
     property color textColor
     state: root.parentState
@@ -66,21 +66,19 @@ AbstractButton {
                 }
             }
         }
-        Loader {
-            Layout.fillWidth: true
-            active: root.iconSource.toString().length > 0
-            visible: active
-            sourceComponent: Button {
-                icon.source: root.iconSource
-                icon.color: root.iconColor
-                icon.height: root.iconHeight
-                icon.width: root.iconWidth
-                background: null
-                onClicked: root.clicked()
+        Button {
+            leftPadding: 0
+            topPadding: 0
+            bottomPadding: 0
+            icon.source: root.iconSource
+            icon.color: root.iconColor
+            icon.height: root.iconHeight
+            icon.width: root.iconWidth
+            background: null
+            onClicked: root.clicked()
 
-                Behavior on icon.color {
-                    ColorAnimation { duration: 150 }
-                }
+            Behavior on icon.color {
+                ColorAnimation { duration: 150 }
             }
         }
     }