Skip to content

Conversation

@edgano
Copy link
Contributor

@edgano edgano commented Apr 17, 2019

ℹ️
If this is your first pull request to Bioconda please ping @bioconda/core so it can be reviewed and to request being added as a member of the Bioconda team. Members of the Bioconda team are able to merge their own pull requests once tests and linting have passed.


  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

PR open on Amap repo to fix the compiling issue


about:
home: "https://web.archive.org/web/20060902044446/http://bio.math.berkeley.edu/amap/"
license: "GPL"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know which version of GPL? Can you add a license_file?

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is in /license/License.txt on the zip file

should I write something like : ??

about:
  home: https://web.archive.org/web/20060902044446/http://bio.math.berkeley.edu/amap/
  license: GPL-2
  license_file: /license/License.txt
  summary: JAMAP is a multiple sequence alignment program based on sequence annealing
  dev_url: https://github.com/mes5k/amap-align

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @bgruening I hope it works now.
But if it's not the best way to add the license just let me know 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good with the most recent changes. I'll merge once it passes testing.

@dpryan79 dpryan79 merged commit 2674c22 into bioconda:master Apr 19, 2019
@dpryan79
Copy link
Contributor

Thanks @edgano !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants