Skip to content

Optimize CleanupAccessTask and checkuseraccess queries #2224

@mikkonie

Description

@mikkonie

I just realized that in my hurry to implement #2217, I did it in a rather unoptimized way.

Right now, I basically query for all ACLs under a specific path and then filter out relevant results in Python. This is, quite obviously, dumb: instead I should filter this already in the query phase for increased efficiency. The current approach might be slow with huge landing zones with restrict_colls enabled.

I'm not sure whether the PRC query interface supports this. If not, there's always the (slightly painful) option of doing raw SQL queries..

If feasible, I'll get this in v1.1.3. If not, postpone until v1.2.

(Is it too late to claim I vibecoded this and blame it on a BS generator? Asking for a friend)

Metadata

Metadata

Assignees

Labels

app: taskflowbackendIssue in the taskflowbackend appinternalChanges invisible to the user or APIs (e.g. refactoring and optimization)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions