Skip to content

Commit fd06505

Browse files
committed
Addressing Rubocop errors
1 parent 0cd8578 commit fd06505

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

CHANGELOG.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
11
## Next Release
22
Your contribution here.
33

4-
* [#170](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/170): Fix various Rubocop warnings and declare dotenv as a dev dependency - [@splittingred](https://github.com/splittingred)
5-
* [#169](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/169): Add frozen_string_literal magic comment to all files - [@splittingred](https://github.com/splittingred)
6-
* [#168](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/168): Move to CircleCI off of TravisCI - [@splittingred](https://github.com/splittingred)
7-
* [#168](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/168): Explicitly declare development dependencies in gemspec - [@splittingred](https://github.com/splittingred)
4+
* [#173](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/173): Loosen Faraday dependency to ~> 1.1.0 - [@bc-johnhebron](https://github.com/bc-johnhebron).
5+
* [#159](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/159): Added new missing fields for an order - [@ranjeetkumarkanaily](https://github.com/ranjeetkumarkanaily).
6+
* [#171](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/171): Fix various Rubocop warnings and declare dotenv as a dev dependency - [@splittingred](https://github.com/splittingred).
7+
* [#170](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/170): Add frozen_string_literal magic comment to all files - [@splittingred](https://github.com/splittingred).
8+
* [#169](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/169): Move to CircleCI off of TravisCI - [@splittingred](https://github.com/splittingred).
9+
* [#168](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/168): Explicitly declare development dependencies in gemspec - [@splittingred](https://github.com/splittingred).
810
* [#167](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/167): Changes handling of HTTP response headers to handle lowercased titles. - [@bc-zachary](https://github.com/bc-zachary).
911
* [#000](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/000): Brief description here. - [@username](https://github.com/username).
1012

1113
## 1.0.1
1214

13-
* [#148](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/148): Loosen Faraday version dependency pin. Update license to explicit MIT. Fix Rubocop and Travis builds. - [@splittingred](https://github.com/splittingred)
14-
* [#142](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/142): Update Faraday gem version. Add support for OAuth SSL options. - [@pedelman](https://github.com/pedelman)
15-
* [#136](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/136): Added accept-encoding: gzip header. - [@adambilsing](https://github.com/adambilsing)
15+
* [#148](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/148): Loosen Faraday version dependency pin. Update license to explicit MIT. Fix Rubocop and Travis builds. - [@splittingred](https://github.com/splittingred).
16+
* [#142](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/142): Update Faraday gem version. Add support for OAuth SSL options. - [@pedelman](https://github.com/pedelman).
17+
* [#136](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/136): Added accept-encoding: gzip header. - [@adambilsing](https://github.com/adambilsing).
1618
* [#128](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/128): Added support for token generation for storefront login. - [@mattolson](https://github.com/mattolson).
1719

1820
## 1.0.0

lib/bigcommerce/config.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def api_url
2222
# @return [String]
2323
#
2424
def base_url
25-
ENV[BC_API_ENDPOINT_ENV_KEY].to_s.empty? ? DEFAULTS[:base_url] : ENV[BC_API_ENDPOINT_ENV_KEY]
25+
ENV[BC_API_ENDPOINT_ENV_KEY].to_s.empty? ? DEFAULTS[:base_url] : ENV.fetch(BC_API_ENDPOINT_ENV_KEY, nil)
2626
end
2727
end
2828
end

lib/bigcommerce/resources/orders/order.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ class Order < Resource
7777
property :store_default_currency_code
7878
property :store_default_to_transactional_exchange_rate
7979
property :tax_provider_id
80-
8180

8281
def self.count(params = {})
8382
get 'orders/count', params

0 commit comments

Comments
 (0)