Skip to content

Commit def011a

Browse files
authored
Merge pull request #142 from pedelman/fix_faraday_dep
Fix issue which caused Faraday to resolve to latest version.
2 parents ae157f9 + d443939 commit def011a

16 files changed

+16
-15
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
Your contribution here.
33

44
* [#000](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/000): Brief description here. - [@username](https://github.com/username).
5+
* [#142](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/142): Update Faraday gem version. Add support for OAuth SSL options. - [@pedelman](https://github.com/pedelman)
56
* [#136](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/136): Added accept-encoding: gzip header. - [@adambilsing](https://github.com/adambilsing)
67
* [#128](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/128): Added support for token generation for storefront login. - [@mattolson](https://github.com/mattolson).
78

Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ end
99
require 'rubocop/rake_task'
1010
RuboCop::RakeTask.new(:rubocop)
1111

12-
task default: [:spec, :rubocop]
12+
task default: %i[spec rubocop]

bigcommerce.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
2020
s.add_development_dependency 'bundler'
2121
s.add_development_dependency 'rake'
2222

23-
s.add_dependency 'faraday', '~> 0.9'
23+
s.add_dependency 'faraday', '~> 0.12.0'
2424
s.add_dependency 'faraday_middleware', '~> 0.10.0'
2525
s.add_dependency 'hashie', '~> 3.4'
2626
s.add_dependency 'jwt', '~> 1.5.4'

lib/bigcommerce/connection.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module Connection
88
}.freeze
99

1010
def self.build(config)
11-
ssl_options = config.ssl if config.auth == 'legacy'
11+
ssl_options = config.ssl || {}
1212
Faraday.new(url: config.api_url, ssl: ssl_options) do |conn|
1313
conn.request :json
1414
conn.headers = HEADERS

lib/bigcommerce/resources/geography/country.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Bigcommerce
66
class Country < Resource
77
include Bigcommerce::ResourceActions.new(
88
uri: 'countries/%d',
9-
disable: [:create, :update, :destroy, :destroy_all]
9+
disable: %i[create update destroy destroy_all]
1010
)
1111

1212
property :id

lib/bigcommerce/resources/geography/state.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Bigcommerce
66
class State < Resource
77
include Bigcommerce::SubresourceActions.new(
88
uri: 'countries/%d/states/%d',
9-
disable: [:create, :update, :destroy, :destroy_all]
9+
disable: %i[create update destroy destroy_all]
1010
)
1111

1212
property :id

lib/bigcommerce/resources/orders/order_coupon.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Bigcommerce
66
class OrderCoupon < Resource
77
include Bigcommerce::SubresourceActions.new(
88
uri: 'orders/%d/coupons/%d',
9-
disable: [:create, :update, :destroy, :destroy_all]
9+
disable: %i[create update destroy destroy_all]
1010
)
1111

1212
property :id

lib/bigcommerce/resources/orders/order_message.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Bigcommerce
66
class OrderMessage < Resource
77
include Bigcommerce::SubresourceActions.new(
88
uri: 'orders/%d/messages/%d',
9-
disable: [:create, :update, :destroy, :destroy_all]
9+
disable: %i[create update destroy destroy_all]
1010
)
1111

1212
property :id

lib/bigcommerce/resources/orders/order_product.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Bigcommerce
66
class OrderProduct < Resource
77
include Bigcommerce::SubresourceActions.new(
88
uri: 'orders/%d/products/%d',
9-
disable: [:create, :update, :destroy, :destroy_all]
9+
disable: %i[create update destroy destroy_all]
1010
)
1111

1212
property :id

lib/bigcommerce/resources/orders/order_shipping_address.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Bigcommerce
66
class OrderShippingAddress < Resource
77
include Bigcommerce::SubresourceActions.new(
88
uri: 'orders/%d/shipping_addresses/%d',
9-
disable: [:create, :update, :destroy, :destroy_all]
9+
disable: %i[create update destroy destroy_all]
1010
)
1111

1212
property :id

lib/bigcommerce/resources/orders/order_status.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module Bigcommerce
77
class OrderStatus < Resource
88
include Bigcommerce::ResourceActions.new(
99
uri: 'order_statuses/%d',
10-
disable: [:create, :update, :destroy, :destroy_all]
10+
disable: %i[create update destroy destroy_all]
1111
)
1212

1313
property :id

lib/bigcommerce/resources/orders/order_tax.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Bigcommerce
66
class OrderTax < Resource
77
include Bigcommerce::SubresourceActions.new(
88
uri: 'orders/%d/taxes/%d',
9-
disable: [:create, :update, :destroy, :destroy_all]
9+
disable: %i[create update destroy destroy_all]
1010
)
1111

1212
property :id

lib/bigcommerce/resources/products/configurable_field.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Bigcommerce
66
class ConfigurableField < Resource
77
include Bigcommerce::SubresourceActions.new(
88
uri: 'products/%d/configurable_fields/%d',
9-
disable: [:create, :update]
9+
disable: %i[create update]
1010
)
1111

1212
property :id

lib/bigcommerce/resources/products/product_option.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Bigcommerce
66
class ProductOption < Resource
77
include Bigcommerce::SubresourceActions.new(
88
uri: 'products/%d/options/%d',
9-
disable: [:create, :update, :destroy, :destroy_all]
9+
disable: %i[create update destroy destroy_all]
1010
)
1111

1212
property :id

lib/bigcommerce/resources/shipping/shipping_method.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Bigcommerce
66
class ShippingMethod < Resource
77
include Bigcommerce::ResourceActions.new(
88
uri: 'shipping/methods/%d',
9-
disable: [:create, :update, :destroy, :destroy_all]
9+
disable: %i[create update destroy destroy_all]
1010
)
1111

1212
property :id

lib/bigcommerce/resources/tax/tax_class.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module Bigcommerce
77
class TaxClass < Resource
88
include Bigcommerce::ResourceActions.new(
99
uri: 'tax_classes/%d',
10-
disable: [:create, :update, :destroy, :destroy_all]
10+
disable: %i[create update destroy destroy_all]
1111
)
1212

1313
property :id

0 commit comments

Comments
 (0)