Skip to content

Commit 3a434b5

Browse files
committed
RUBY-16: Move to CircleCI
1 parent 9e3fc77 commit 3a434b5

File tree

15 files changed

+404
-180
lines changed

15 files changed

+404
-180
lines changed

.circleci/config.yml

Lines changed: 86 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
1+
version: 2.1
2+
3+
orbs:
4+
ci: bigcommerce/internal@volatile
5+
ruby: bigcommerce/internal-ruby@volatile
6+
7+
defaults: &defaults
8+
notify_failure: false
9+
10+
ruby_2_6_defaults: &ruby_2_6_defaults
11+
<<: *defaults
12+
e:
13+
name: ruby/ruby
14+
ruby-version: '2.6'
15+
16+
ruby_2_7_defaults: &ruby_2_7_defaults
17+
<<: *defaults
18+
e:
19+
name: ruby/ruby
20+
ruby-version: '2.7'
21+
22+
ruby_3_0_defaults: &ruby_3_0_defaults
23+
<<: *defaults
24+
e:
25+
name: ruby/ruby
26+
ruby-version: '3.0'
27+
28+
ruby_3_1_defaults: &ruby_3_1_defaults
29+
<<: *defaults
30+
e:
31+
name: ruby/ruby
32+
ruby-version: '3.1'
33+
34+
workflows:
35+
version: 2
36+
ruby_2_6:
37+
jobs:
38+
- ruby/bundle-audit:
39+
<<: *ruby_2_6_defaults
40+
name: ruby-2_6-bundle_audit
41+
- ruby/rubocop:
42+
<<: *ruby_2_6_defaults
43+
name: ruby-2_6-rubocop
44+
- ruby/rspec-unit:
45+
<<: *ruby_2_6_defaults
46+
name: ruby-2_6-rspec_unit
47+
db: false
48+
code-climate: false
49+
ruby_2_7:
50+
jobs:
51+
- ruby/bundle-audit:
52+
<<: *ruby_2_7_defaults
53+
name: ruby-2_7-bundle_audit
54+
- ruby/rubocop:
55+
<<: *ruby_2_7_defaults
56+
name: ruby-2_7-rubocop
57+
- ruby/rspec-unit:
58+
<<: *ruby_2_7_defaults
59+
name: ruby-2_7-rspec_unit
60+
db: false
61+
code-climate: false
62+
ruby_3_0:
63+
jobs:
64+
- ruby/bundle-audit:
65+
<<: *ruby_3_0_defaults
66+
name: ruby-3_0-bundle_audit
67+
- ruby/rubocop:
68+
<<: *ruby_3_0_defaults
69+
name: ruby-3_0-rubocop
70+
- ruby/rspec-unit:
71+
<<: *ruby_3_0_defaults
72+
name: ruby-3_0-rspec_unit
73+
db: false
74+
ruby_3_1:
75+
jobs:
76+
- ruby/bundle-audit:
77+
<<: *ruby_3_1_defaults
78+
name: ruby-3_1-bundle_audit
79+
- ruby/rubocop:
80+
<<: *ruby_3_1_defaults
81+
name: ruby-3_1-rubocop
82+
- ruby/rspec-unit:
83+
<<: *ruby_3_1_defaults
84+
name: ruby-3_1-rspec_unit
85+
db: false
86+
code-climate: false

.rubocop.yml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
AllCops:
2+
TargetRubyVersion: 2.6
3+
NewCops: enable
4+
SuggestExtensions: false
25
Exclude:
36
- spec/**/*
47
- .bundle/**/*
58
- bin/**/*
69
- vendor/**/*
710
- examples/**/*
11+
require:
12+
- rubocop-performance
813

914
Layout/LineLength:
1015
Max: 120
@@ -22,5 +27,33 @@ Style/Documentation:
2227
Style/FormatStringToken:
2328
Enabled: false
2429

30+
Naming/VariableNumber:
31+
Enabled: false
32+
33+
########################################################################################################################
34+
# TO FIX
35+
########################################################################################################################
36+
Style/FrozenStringLiteralComment:
37+
Enabled: false
38+
39+
Layout/EmptyLineAfterGuardClause:
40+
Enabled: false
41+
42+
Lint/MissingSuper:
43+
Enabled: false
44+
45+
Performance/MethodObjectAsBlock:
46+
Exclude:
47+
- lib/bigcommerce.rb
48+
49+
Lint/NonDeterministicRequireOrder:
50+
Exclude:
51+
- lib/bigcommerce.rb
52+
53+
# we should deprecate Ruby < 2.7 support ASAP
2554
Gemspec/RequiredRubyVersion:
2655
Enabled: false
56+
57+
Style/ExplicitBlockArgument:
58+
Exclude:
59+
- lib/bigcommerce.rb

.travis.yml

Lines changed: 0 additions & 13 deletions
This file was deleted.

bigcommerce.gemspec

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
lib = File.expand_path('../lib', __FILE__)
2-
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
1+
# frozen_string_literal : true
2+
3+
$LOAD_PATH.unshift(File.expand_path('lib', __dir__))
34
require 'bigcommerce/version'
45

56
Gem::Specification.new do |s|
@@ -13,12 +14,20 @@ Gem::Specification.new do |s|
1314
s.homepage = 'https://github.com/bigcommerce/bigcommerce-api-ruby'
1415
s.summary = 'Ruby client library for the BigCommerce API'
1516
s.description = s.summary
17+
s.metadata['rubygems_mfa_required'] = 'true'
1618

1719
s.require_paths = ['lib']
1820
s.files = Dir['README.md', 'lib/**/*', 'bigcommerce.gemspec']
1921

2022
s.add_development_dependency 'bundler'
21-
s.add_development_dependency 'rake'
23+
s.add_development_dependency 'bundler-audit', '~> 0.6'
24+
s.add_development_dependency 'pry', '>= 0.12'
25+
s.add_development_dependency 'rake', '>= 12.0'
26+
s.add_development_dependency 'rspec', '~> 3.8'
27+
s.add_development_dependency 'rspec_junit_formatter', '~> 0.4'
28+
s.add_development_dependency 'rubocop', '~> 1.0'
29+
s.add_development_dependency 'rubocop-performance', '>= 1.5'
30+
s.add_development_dependency 'simplecov', '~> 0.15'
2231

2332
s.add_dependency 'faraday', '~> 0.11'
2433
s.add_dependency 'faraday_middleware', '~> 0.11'

lib/bigcommerce.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require 'hashie'
24
require 'faraday_middleware'
35
require 'bigcommerce/version'

lib/bigcommerce/exception.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
module Bigcommerce
24
class HttpError < StandardError
35
attr_accessor :response_headers
@@ -41,7 +43,7 @@ module HttpErrors
4143
}.freeze
4244

4345
def throw_http_exception!(code, env)
44-
return unless ERRORS.keys.include? code
46+
return unless ERRORS.key?(code)
4547

4648
response_headers = Faraday::Utils::Headers.new(env.response_headers)
4749

lib/bigcommerce/middleware/auth.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
module Bigcommerce
24
module Middleware
35
class Auth < Faraday::Middleware

spec/bigcommerce/bigcommerce_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
RSpec.describe Bigcommerce do
24
let(:middleware) do
35
api.instance_variable_get('@builder').instance_variable_get('@handlers')

spec/bigcommerce/unit/actions_spec.rb

Lines changed: 0 additions & 149 deletions
This file was deleted.

0 commit comments

Comments
 (0)