Lint JS

spencerfinnell · spencerfinnell · commit e1b01605ddff · 2018-12-20T15:10:00.000-05:00
diff --git a/package.json b/package.json
@@ -53,6 +53,11 @@
 			}
 		]
 	},
+	"eslintConfig": {
+		"extends": [
+			"plugin:@wordpress/eslint-plugin/recommended"
+		]
+	},
 	"scripts": {
 		"build": "cross-env NODE_ENV=production webpack",
 		"check-npm-licenses": "./bin/wp-bin/bin/check-npm-licenses.sh; exit 0",
diff --git a/resources/assets/js/app/navbar.js b/resources/assets/js/app/navbar.js
@@ -1,3 +1,5 @@
+/* global _ */
+
 /**
  * External dependencies.
  */
diff --git a/resources/assets/js/customize/controls/typography.js b/resources/assets/js/customize/controls/typography.js
@@ -131,4 +131,4 @@
 		const event = new Event( 'change' );
 		familyInput.dispatchEvent( event );
 	} );
-} ) ();
+} )();
diff --git a/resources/assets/js/customize/controls/walkthrough.js b/resources/assets/js/customize/controls/walkthrough.js
@@ -1,4 +1,4 @@
-/* global wp, bigboxCustomizeControls, _ */
+/* global wp, bigboxCustomizeControls */
 
 /**
  * External dependencies.
diff --git a/resources/assets/js/facetwp/navbar-search.js b/resources/assets/js/facetwp/navbar-search.js
@@ -1,4 +1,4 @@
-/* global FWP, _ */
+/* global FWP */
 
 /**
  * External dependencies.
diff --git a/resources/assets/js/license-manager/index.js b/resources/assets/js/license-manager/index.js
@@ -1,4 +1,4 @@
-/* global wp, BigBoxLicenseManager, Backbone */
+/* global BigBoxLicenseManager */
 
 /**
  * Internal dependencies.
diff --git a/resources/assets/js/license-manager/models/license.js b/resources/assets/js/license-manager/models/license.js
@@ -1,4 +1,4 @@
-/* global Backbone */
+/* global BigBoxLicenseManager, Backbone */
 
 /**
  * External dependencies.
diff --git a/resources/assets/js/license-manager/views/deactivate.js b/resources/assets/js/license-manager/views/deactivate.js
@@ -1,4 +1,4 @@
-/* global wp */
+/* global BigBoxLicenseManager, wp */
 
 /**
  * Internal dependencies.
diff --git a/resources/assets/js/license-manager/views/form.js b/resources/assets/js/license-manager/views/form.js
@@ -1,4 +1,4 @@
-/* global wp */
+/* global BigBoxLicenseManager, wp */
 
 /**
  * Internal dependencies.
diff --git a/resources/assets/js/utils/index.js b/resources/assets/js/utils/index.js
@@ -32,7 +32,9 @@ export const isHidden = ( el ) => {
  * @return {boolean} If the DOM element is visible.
  */
 export const findAncestor = ( el, className ) => {
-	while ( ( el = el.parentElement ) && ! hasClass( el, className ) );
+	while ( ( el = el.parentElement ) && ! hasClass( el, className ) ) {
+
+	}
 
 	return el;
 };
diff --git a/resources/assets/js/utils/partials.js b/resources/assets/js/utils/partials.js
@@ -1,4 +1,4 @@
-/* global $, _ */
+/* global bigbox, $, _ */
 
 const partialCache = {};
 
diff --git a/resources/assets/js/woocommerce/cart.js b/resources/assets/js/woocommerce/cart.js
@@ -1,4 +1,4 @@
-/* global $, bigbox, URLSearchParams, FormData */
+/* global $, wp, URLSearchParams, FormData */
 
 /**
  * External dependencies.
diff --git a/resources/assets/js/woocommerce/checkout.js b/resources/assets/js/woocommerce/checkout.js
@@ -1,4 +1,4 @@
-/* global $, wc_checkout_params, URLSearchParams, FormData */
+/* global $, wp, wc_checkout_params, URLSearchParams, FormData */
 
 /**
  * Internal dependencies.
diff --git a/resources/assets/js/woocommerce/quantity.js b/resources/assets/js/woocommerce/quantity.js
@@ -1,4 +1,4 @@
-/* global bigbox */
+/* global bigbox, _ */
 
 const { globalMax } = bigbox.woocommerce.products.quantitySelector;
 

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,11 @@`
`53`	`53`	`}`
`54`	`54`	`]`
`55`	`55`	`},`
	`56`	`+ "eslintConfig": {`
	`57`	`+ "extends": [`
	`58`	`+ "plugin:@wordpress/eslint-plugin/recommended"`
	`59`	`+ ]`
	`60`	`+ },`
`56`	`61`	`"scripts": {`
`57`	`62`	`"build": "cross-env NODE_ENV=production webpack",`
`58`	`63`	`"check-npm-licenses": "./bin/wp-bin/bin/check-npm-licenses.sh; exit 0",`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+/* global _ */`
	`2`	`+`
`1`	`3`	`/**`
`2`	`4`	`* External dependencies.`
`3`	`5`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* global wp, bigboxCustomizeControls, _ */`
	`1`	`+/* global wp, bigboxCustomizeControls */`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* External dependencies.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* global FWP, _ */`
	`1`	`+/* global FWP */`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* External dependencies.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* global wp, BigBoxLicenseManager, Backbone */`
	`1`	`+/* global BigBoxLicenseManager */`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* Internal dependencies.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* global Backbone */`
	`1`	`+/* global BigBoxLicenseManager, Backbone */`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* External dependencies.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* global wp */`
	`1`	`+/* global BigBoxLicenseManager, wp */`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* Internal dependencies.`