Skip to content

feat(schema): Add selectors to file rules #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2025
Merged

feat(schema): Add selectors to file rules #2079

merged 2 commits into from
Mar 17, 2025

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Mar 6, 2025

Closes #2052.

@effigies effigies added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Mar 6, 2025
@effigies effigies requested a review from erdalkaraca as a code owner March 6, 2025 21:13
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (3b6d2f7) to head (be32278).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2079   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files          17       17           
  Lines        1499     1499           
=======================================
  Hits         1238     1238           
  Misses        261      261

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@effigies
Copy link
Collaborator Author

effigies commented Mar 6, 2025

@yarikoptic Q: Do you think it would be better to target the maint/1.10.0 branch so that there's a version of the 1.10.0 schema that has this feature, or should we just aim to include it in the next BIDS release?

@yarikoptic yarikoptic mentioned this pull request Mar 6, 2025
Open
@yarikoptic
Copy link
Collaborator

filed

and sure -- looks like a patch-worthy fix, so why not into maint/?

@effigies effigies changed the base branch from master to maint/1.10.0 March 7, 2025 00:43
@effigies effigies force-pushed the schema/file-selectors branch from be32278 to 4c39633 Compare March 7, 2025 00:45
@effigies
Copy link
Collaborator Author

@yarikoptic @rwblair Review would be appreciated.

rwblair
rwblair approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@rwblair rwblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

For future consideration:

  • selectors on directory naming rules
  • inheritance principle for selectors 😈😈😈

@effigies
Copy link
Collaborator Author

inheritance principle for selectors 😈😈😈

I don't know what that means?

@effigies effigies merged commit 6ee0e9c into bids-standard:maint/1.10.0 Mar 17, 2025
17 of 18 checks passed
@effigies effigies added exclude-from-changelog This item will not feature in the automatically generated changelog and removed needs review labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwblair rwblair rwblair approved these changes

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca is a code owner

@tsalo tsalo Awaiting requested review from tsalo tsalo is a code owner

@ezemikulan ezemikulan Awaiting requested review from ezemikulan

@sappelhoff sappelhoff Awaiting requested review from sappelhoff

@DimitriPapadopoulos DimitriPapadopoulos Awaiting requested review from DimitriPapadopoulos

Assignees
No one assigned
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SCHEMA] Proposal: Add selectors to file rules
3 participants
@effigies @yarikoptic @rwblair